-
Notifications
You must be signed in to change notification settings - Fork 24
updating 3p actions from version ID to commit SHA #456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating 3p actions from version ID to commit SHA #456
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of changes:
- actions/checkout@v3 -> actions/checkout@08c6903 (v5.0.0)
- actions/checkout@v4 -> actions/checkout@08c6903 (v5.0.0)
- actions/setup-dotnet@v2 -> actions/setup-dotnet@d4c9434 (v5.0.0)
- actions/setup-dotnet@v4 -> actions/setup-dotnet@d4c9434 (v5.0.0)
- actions/setup-java@v4 -> actions/setup-java@dded088 (v5.0.0)
- actions/setup-node@v4 -> actions/setup-node@a0853c2 (v5.0.0)
- actions/setup-python@v5 -> actions/setup-python@e797f83 (v6.0.0)
- actions/upload-artifact@v4 -> actions/upload-artifact@ea165f8 (v4.6.2)
- aws-actions/amazon-ecr-login@v2 -> aws-actions/amazon-ecr-login@062b18b (v2.0.1)
- aws-actions/aws-secretsmanager-get-secrets@v1 -> aws-actions/aws-secretsmanager-get-secrets@a9a7eb4 (v2.0.10)
- aws-actions/aws-secretsmanager-get-secrets@v2 -> aws-actions/aws-secretsmanager-get-secrets@a9a7eb4 (v2.0.10)
- aws-actions/configure-aws-credentials@v4 -> aws-actions/configure-aws-credentials@a03048d (v5.0.0)
- gradle/actions/setup-gradle@v3 -> gradle/actions@ed40850 (v4.4.3)
- gradle/actions/setup-gradle@v4 -> gradle/actions@ed40850 (v4.4.3)
- hashicorp/setup-terraform@v2 -> hashicorp/setup-terraform@b9cd54a (v3.1.2)
- ruby/[email protected] -> ruby/setup-ruby@32110d4 (v1.221.0)
@Miqueasher - my biggest concern is all the actions/setup-<language>vX -> vY
- I'm worried later versions may not support he same language versions. E.g. does setup-dotnetv5
support the same language versions as setup-dotnet@v2
, etc. Same with setup-gradlev3 -> v4
(though in that case, the only usage is in pr-build, which we know will or will not work based on the checks run against this PR).
Co-authored-by: Thomas Pierce <[email protected]>
This pr updates all 3p actions from using version ID tags to being pinned with their commit SHA.
Git revert is safe unless SHA pinning is enforced for this repository in the settings. In that case all pinned commit SHA must be corresponding to the version tag that was specified before this pr. Alternatively functionality and/or arguments of commands must be updated to satisfy changes between the versions.
References:
https://github.com/actions/checkout
https://github.com/actions/setup-python
https://github.com/actions/setup-java
https://github.com/actions/setup-node
https://github.com/actions/cache
https://github.com/actions/upload-artifact
https://github.com/aws-actions/configure-aws-credentials
https://github.com/actions/download-artifact
https://github.com/aws-actions/aws-secretsmanager-get-secrets
https://github.com/gradle/actions/blob/f8140229023a7015c7ce4df6f7c390a3cace8f83/docs/deprecation-upgrade-guide.md#using-the-action-to-execute-gradle-via-the-arguments-parameter-is-deprecated
https://github.com/hashicorp/setup-terraform
https://github.com/ruby/setup-ruby
https://github.com/aws-actions/amazon-ecr-login
https://github.com/actions/setup-dotnet
NOTE: TESTS RUNNING ON A SINGLE EKS CLUSTER CANNOT BE RUN IN PARALLEL. See the needs keyword to run tests in succession.
e2e-playground
in us-east-1 and eu-central-2e2e-playground
in us-east-1 and eu-central-2e2e-playground
in us-east-1 and eu-central-2By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.