Potential fix for code scanning alert no. 8: Workflow does not contain permissions #466
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/aws-observability/aws-application-signals-test-framework/security/code-scanning/8
To fix this issue, an explicit
permissions
block should be added to theall-codeql-checks-pass
job in.github/workflows/codeql.yml
, with the minimal permissions necessary for its steps. The job merely checks workflow/job results and does not interact with or modify repository contents, socontents: read
is both GitHub's recommended minimal starting point and sufficient for this case.The
permissions
block must be added at the same indentation level asruns-on
within theall-codeql-checks-pass
job definition (after line 109), to avoid affecting the global workflow or other jobs.Suggested fixes powered by Copilot Autofix. Review carefully before merging.