Potential fix for code scanning alert no. 12: Workflow does not contain permissions #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/aws-observability/aws-application-signals-test-framework/security/code-scanning/12
The best way to address this issue is to explicitly set permissions at the workflow (root) level, so that all jobs default to these minimal permissions unless otherwise overridden in a particular job. For typical CI workflows like this,
contents: readis usually sufficient, as no job writes to the repository, handles issues, or manipulates pull requests. This ensures that theGITHUB_TOKENassociated with all jobs is as restricted as possible.Changes required:
permissions:block at the root of.github/workflows/pr-build.yml(just belowname: ...and aboveon:).contents: read.No imports, additional libraries, or other definitions are required for this change, as it is a YAML configuration fix.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.