Trigger performance test after successful CI run.#818
Trigger performance test after successful CI run.#818jefchien merged 5 commits intoaws-observability:mainfrom
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #818 +/- ##
==========================================
- Coverage 55.14% 51.93% -3.22%
==========================================
Files 11 11
Lines 301 387 +86
==========================================
+ Hits 166 201 +35
- Misses 118 169 +51
Partials 17 17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| run: python e2etest/get-performance-model-table.py ${{ needs.get-testing-version.outputs.testing_version }} | ||
|
|
||
| - name: Store benchmark result | ||
| uses: jefchien/github-action-benchmark@v1.11.12-alpha2 |
There was a problem hiding this comment.
Anyway for us to know the parameters that are required in your private GitHub action thought?
There was a problem hiding this comment.
It's a fork of the existing https://github.com/benchmark-action/github-action-benchmark. The change was needed to pass the workflow dispatch input SHA into the action so the benchmarks are tagged with the correct commit. I have a PR benchmark-action/github-action-benchmark#93 open for the change, but until that gets merged or another method of inserting the commit is found, we'll need to use the fork.
There was a problem hiding this comment.
Got cha. Make more sense to me now. Currently reviewing yours other PR as well.
| """ | ||
| Splits models by test | ||
| """ | ||
| benchmark_data = [] |
There was a problem hiding this comment.
IMO, instead of using only [], using list(dict) would have more clarification in defining what is added into the list.
jefchien
force-pushed
the
auto-perf-test
branch
2 times, most recently
from
15f8e93 to
b50f8a6
Compare
jefchien
force-pushed
the
auto-perf-test
branch
from
b50f8a6 to
3bf3652
Compare
6 participants
Description: Removes the scheduled performance tests. Also, auto-commits results to gh-pages and updates benchmarking.
Link to tracking Issue: #811
Testing: Tested it with my fork.
Documentation: