Skip to content

Conversation

thpierce
Copy link
Contributor

@thpierce thpierce commented Sep 19, 2025

Fixes style issues that kept showing up in PRs (e.g. #244), and then some:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

- Fix nullable type spacing and null literal warnings
- Configure build to fail on warnings to prevent future issues
@thpierce thpierce requested a review from a team as a code owner September 19, 2025 00:19
@thpierce thpierce added the skip changelog doesn't need a CHANGELOG entry label Sep 19, 2025
@thpierce thpierce enabled auto-merge (squash) September 19, 2025 00:20
- Enable XML documentation generation to fix SA0001 error
- Add missing newlines at end of files (SA1518)
- Remove space after 'new' keyword (SA1000)
- Add tuple element names and fix casing (SA1414, SA1316)
- Fix tuple element references in SqlUrlParser methods
- Remove empty AWSDistroOpenTelemetryEventSource.cs file (#16 (comment))
- Fix malformed XML documentation in AlwaysRecordSampler.cs
- Fix XML documentation formatting in AwsMetricAttributeGenerator.cs with proper closing tags
- Update tuple element casing and variable references in LambdaWrapper.cs
- Add comprehensive XML documentation to RegionalResourceArnParser.cs
- Renamed MetricAttributeGenerator.cs -> IMetricAttributeGenerator.cs and SqlUrlParser.cs -> SqsUrlParser.cs
- Fix XML documentation formatting in AlwaysRecordSampler.cs by removing <p> tags
- Fix XML documentation in AwsMetricAttributeGenerator.cs by removing malformed <p> tags and fixing braces
- Update tuple element casing in LambdaWrapper.cs ExtractOriginalHandler method
- Standardize variable naming to match tuple element names (HandlerMethod, HandlerInstance)
@thpierce thpierce changed the title fix: resolve nullable warnings and enforce TreatWarningsAsErrors fix: resolve StyleCop analyzer errors and improve code compliance Sep 19, 2025
@thpierce thpierce merged commit fa685e1 into main Sep 19, 2025
16 checks passed
@thpierce thpierce deleted the fix_style branch September 19, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changelog doesn't need a CHANGELOG entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants