generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 17
fix: resolve StyleCop analyzer errors and improve code compliance #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix nullable type spacing and null literal warnings - Configure build to fail on warnings to prevent future issues
- Enable XML documentation generation to fix SA0001 error - Add missing newlines at end of files (SA1518) - Remove space after 'new' keyword (SA1000) - Add tuple element names and fix casing (SA1414, SA1316) - Fix tuple element references in SqlUrlParser methods
- Remove empty AWSDistroOpenTelemetryEventSource.cs file (#16 (comment)) - Fix malformed XML documentation in AlwaysRecordSampler.cs - Fix XML documentation formatting in AwsMetricAttributeGenerator.cs with proper closing tags - Update tuple element casing and variable references in LambdaWrapper.cs - Add comprehensive XML documentation to RegionalResourceArnParser.cs - Renamed MetricAttributeGenerator.cs -> IMetricAttributeGenerator.cs and SqlUrlParser.cs -> SqsUrlParser.cs
- Fix XML documentation formatting in AlwaysRecordSampler.cs by removing <p> tags - Fix XML documentation in AwsMetricAttributeGenerator.cs by removing malformed <p> tags and fixing braces - Update tuple element casing in LambdaWrapper.cs ExtractOriginalHandler method - Standardize variable naming to match tuple element names (HandlerMethod, HandlerInstance)
vastin
reviewed
Sep 19, 2025
src/AWS.Distro.OpenTelemetry.AutoInstrumentation/IMetricAttributeGenerator.cs
Show resolved
Hide resolved
vastin
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes style issues that kept showing up in PRs (e.g. #244), and then some:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.