fix: prevent script injection in workflows#336
Closed
thpierce wants to merge 1 commit intorelease/v1.8.xfrom
Closed
fix: prevent script injection in workflows#336thpierce wants to merge 1 commit intorelease/v1.8.xfrom
thpierce wants to merge 1 commit intorelease/v1.8.xfrom
Conversation
Fixes https://t.corp.amazon.com/V1559008677 Move github.event references to env vars to prevent script injection vulnerabilities in workflow run steps. This follows the same pattern as aws-observability/aws-otel-js-instrumentation@3d9ac9d By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Contributor
Author
|
Closing to redo |
thpierce
deleted the
fix/prevent-script-injection-release-v1.8.x-cherrypick
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://t.corp.amazon.com/V1559008677
Cherry-picked from main (371c614) with conflict resolution.
Additional changes beyond cherry-pick:
Move github.event references to env vars to prevent script injection vulnerabilities in workflow run steps.
This follows the same pattern as aws-observability/aws-otel-js-instrumentation@3d9ac9d
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.