Remove spans with ec2 metadata ip address from metrics #1015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrryr
force-pushed
the
ec2-metadata-api-span-remove
branch
from
40c37bc to
ff3554b
Compare
This was referenced Feb 7, 2025
mxiamxia
reviewed
Feb 10, 2025
...src/main/java/software/amazon/opentelemetry/javaagent/providers/AwsSpanMetricsProcessor.java
Outdated
Show resolved
Hide resolved
mxiamxia
approved these changes
Feb 11, 2025
harrryr
added a commit
to aws-observability/aws-otel-js-instrumentation
that referenced
this pull request
Feb 13, 2025
*Issue #, if available:* ADOT SDK resource detectors by default have enabled a few AWS resource detector which will call EC2 metadata API endpoints. These activities have been captured by auto-instrumentation and generated AppSignals metrics. *Description of changes:* Suppress AwsSpanMetricsProcessor from generating metrics when the RemoteService points to 169.254.169.254 *Testing*: Tested using Java Adot: aws-observability/aws-otel-java-instrumentation#1015 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
harrryr
added a commit
to aws-observability/aws-otel-python-instrumentation
that referenced
this pull request
Feb 13, 2025
*Issue #, if available:* ADOT SDK resource detectors by default have enabled a few AWS resource detector which will call EC2 metadata API endpoints. These activities have been captured by auto-instrumentation and generated AppSignals metrics. *Description of changes:* Suppress AwsSpanMetricsProcessor from generating metrics when the RemoteService points to 169.254.169.254 *Testing*: Tested using Java Adot: aws-observability/aws-otel-java-instrumentation#1015 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
XinRanZhAWS
pushed a commit
that referenced
this pull request
Mar 11, 2025
*Issue #, if available:* ADOT SDK resource detectors by default have enabled a few AWS resource detector which will call EC2 metadata API endpoints. These activities have been captured by auto-instrumentation and generated AppSignals metrics. These calls should be present in traces, but not in metrics. *Description of changes:* Suppress AwsSpanMetricsProcessor from generating metrics when the RemoteService points to `169.254.169.254` *Testing* Deployed two EC2 instance with Java sample application and ADOT Java - `sample-application-2025-02-06-test`: ADOT Java with changes in this PR - `sample-application-2025-02-06`: Public latest ADOT Java *Traces:* Present from both EC2 instance   *Metrics*: Present only for `sample-application-2025-02-06`:  *Logs*: Present only for `sample-application-2025-02-06`: By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
ADOT SDK resource detectors by default have enabled a few AWS resource detector which will call EC2 metadata API endpoints. These activities have been captured by auto-instrumentation and generated AppSignals metrics.
These calls should be present in traces, but not in metrics.
Description of changes:
Suppress AwsSpanMetricsProcessor from generating metrics when the RemoteService points to
169.254.169.254Testing
Deployed two EC2 instance with Java sample application and ADOT Java
sample-application-2025-02-06-test: ADOT Java with changes in this PRsample-application-2025-02-06: Public latest ADOT JavaTraces:
Present from both EC2 instance
Metrics:
Present only for
sample-application-2025-02-06:Logs:
Present only for
sample-application-2025-02-06:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.