SigV4 Authentication support for http exporter #1019
Conversation
...ftware/amazon/opentelemetry/javaagent/providers/AwsApplicationSignalsCustomizerProvider.java
Outdated
Show resolved
Hide resolved
...der/src/main/java/software/amazon/opentelemetry/javaagent/providers/OtlpAwsSpanExporter.java
Outdated
Show resolved
Hide resolved
...src/test/java/software/amazon/opentelemetry/javaagent/providers/OtlpAwsSpanExporterTest.java
Show resolved
Hide resolved
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1019 +/- ##
=============================================
- Coverage 85.71% 68.56% -17.15%
- Complexity 19 328 +309
=============================================
Files 3 27 +24
Lines 49 1244 +1195
Branches 5 170 +165
=============================================
+ Hits 42 853 +811
- Misses 3 334 +331
- Partials 4 57 +53 ☔ View full report in Codecov by Sentry. |
...der/src/main/java/software/amazon/opentelemetry/javaagent/providers/OtlpAwsSpanExporter.java
Show resolved
Hide resolved
...der/src/main/java/software/amazon/opentelemetry/javaagent/providers/OtlpAwsSpanExporter.java
Outdated
Show resolved
Hide resolved
...src/test/java/software/amazon/opentelemetry/javaagent/providers/OtlpAwsSpanExporterTest.java
Outdated
Show resolved
Hide resolved
...der/src/main/java/software/amazon/opentelemetry/javaagent/providers/OtlpAwsSpanExporter.java
Show resolved
Hide resolved
| // For Udp emitter | ||
| compileOnly("io.opentelemetry:opentelemetry-exporter-otlp-common") | ||
| // For HTTP SigV4 emitter | ||
| implementation("software.amazon.awssdk:auth:2.30.14") |
There was a problem hiding this comment.
why use fixed versions of http auth. Will it cause conflicts when customers use a different version in their application?
| implementation("com.amazonaws:aws-java-sdk-core:1.12.773") | ||
| // Export configuration | ||
| compileOnly("io.opentelemetry:opentelemetry-exporter-otlp") | ||
| implementation("io.opentelemetry:opentelemetry-exporter-otlp") |
There was a problem hiding this comment.
Why do we change it to implementation?
There was a problem hiding this comment.
I changed it from compileOnly to implementation is because the http exporter is now a required dependency when I began executing the auto instrumentation at runtime. Otherwise I believe I was getting a ClassNotFoundException everytime I ran the exporter
There was a problem hiding this comment.
We changed it to compileOnly due to a regression it introduced, see #651. You need to figure out a way to avoid the same issue before submit the change.
…lity#1019)" This reverts commit 83e5ade.
*Description of changes:* This reverts SigV4 Exporter added in PR #1019 as it is unstable and is blocking the current Java V2 release By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue #, if available: Adding SigV4 Authentication extension for Exporting traces to OTLP CloudWatch endpoint without needing to explictily install the collector. Description of changes: Added a new class that extends upstream's OTLP http span exporter. Overrides the export method so that if the endpoint is CW, we add an extra step of injecting SigV4 authentication to the headers. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Mahad Janjua <[email protected]>
*Description of changes:* This reverts SigV4 Exporter added in PR #1019 as it is unstable and is blocking the current Java V2 release By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
5 participants
Issue #, if available:
Adding SigV4 Authentication extension for Exporting traces to OTLP CloudWatch endpoint without needing to explictily install the collector.
Description of changes:
Added a new class that extends upstream's OTLP http span exporter. Overrides the export method so that if the endpoint is CW, we add an extra step of injecting SigV4 authentication to the headers.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.