add version.gradle.kts #1122
Open
add version.gradle.kts #1122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have a version file here: https://github.com/aws-observability/aws-otel-java-instrumentation/blob/main/.github/patches/versions I believe it is currently used in building the lambda layer. Do we need to do something about that? |
srprash
approved these changes
Aug 13, 2025
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1122 +/- ##
=============================================
- Coverage 85.71% 52.70% -33.01%
- Complexity 19 416 +397
=============================================
Files 3 53 +50
Lines 49 2584 +2535
Branches 5 348 +343
=============================================
+ Hits 42 1362 +1320
- Misses 3 1131 +1128
- Partials 4 91 +87 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
(copied from #1121)
The current version for ADOT SDK and Lambda Layer releases is only provided manually in the release workflow and auto-generated by the nebula release plugin based on previous tags, but never specified in the code. Adding a version file will provide explicit version management and make it easier to track upcoming releases. adotVersion is currently set to 2.11.1-dev0, following the convention used by our other ADOT projects (Python, .NET, NodeJS).
The ADOT Lambda layer was previously given a version name after the upstream OpenTelemetry instrumentation. For example, for the most recent 2.11.1 release -- which still depends on OpenTelemetry Java Instrumentation 2.11.0 -- logs the following upon startup:
This change has the Lambda layer's Otel agent consume the version provided in version.gradle.kts. For example, after building locally, the layer will now log:
which is the accurate version.
Soon we will add pre-release and post-release workflows like the other language ADOT repos to automatically bump the version number. This is part of our work to align the release process for all 4 languages and streamline releases for future engineers.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.