Skip to content

Change scheduled daily scan to run 3 times per day #1140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 13, 2025
Merged

Conversation

liustve
Copy link
Contributor

@liustve liustve commented Aug 12, 2025

Description of changes:

Daily Scan failure metrics often show up for one day and are back to normal 24 hours later. The workflow error for these failures is always some timeout/transient issue that goes away if the workflow is manually re-run. We want to try to avoid alarming on these failures while catching actual, repeated failures.

Moving the cadence of the daily scan to run 3 times per day with 12-6-6 hour intervals: 02:00, 14:00, 20:00 UTC times.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@liustve liustve requested a review from a team as a code owner August 12, 2025 20:04
@liustve
Copy link
Contributor Author

liustve commented Aug 13, 2025

As discussed on slack, it actually doesn't really matter when these scans get run since the evaluation period for the day can't be controlled so developers can still get paged at 12 AM

@liustve liustve merged commit 0dcd074 into main Aug 13, 2025
5 checks passed
@liustve liustve deleted the change-scan-pattern branch August 13, 2025 17:48
liustve added a commit to aws-observability/aws-otel-js-instrumentation that referenced this pull request Aug 13, 2025
*Description of changes:*
JS version of this PR:
aws-observability/aws-otel-java-instrumentation#1140

By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.
liustve added a commit to aws-observability/aws-otel-python-instrumentation that referenced this pull request Aug 13, 2025
*Description of changes:*
Python version of this PR:
aws-observability/aws-otel-java-instrumentation#1140



By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants