Add docker login for daily scan workflow image scanning #1144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 12, 2025
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1144 +/- ##
=============================================
- Coverage 85.71% 52.70% -33.01%
- Complexity 19 416 +397
=============================================
Files 3 53 +50
Lines 49 2584 +2535
Branches 5 348 +343
=============================================
+ Hits 42 1362 +1320
- Misses 3 1131 +1128
- Partials 4 91 +87 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
thpierce
previously approved these changes
Aug 13, 2025
thpierce
approved these changes
Aug 13, 2025
liustve
added a commit
to aws-observability/aws-otel-python-instrumentation
that referenced
this pull request
Aug 13, 2025
*Description of changes:* Python version of this PR: aws-observability/aws-otel-java-instrumentation#1144 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
liustve
added a commit
to aws-observability/aws-otel-js-instrumentation
that referenced
this pull request
Aug 13, 2025
*Description of changes:* JavaScript version of this PR: aws-observability/aws-otel-java-instrumentation#1144 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The current daily scan's image scan workflow would often fail with the following error:
Turns out the issue is related to making unauthenticated GET request calls to public ECR images.
We make these calls both in the
pr_build(explanation can be found in the code comment) and inowasp.yml. Likely, our GET requests to pull the ADOT image are being throttled as a result.aws-otel-java-instrumentation/.github/actions/image_scan/action.yml
Line 24 in 7ffb3d4
owasp.ymlimage scanning.Testing
200 Image Scan test runs with docker login (0 failed jobs): https://github.com/aws-observability/aws-otel-java-instrumentation/actions/runs/16922020570/job/47950156083
200 Image Scan test runs w/o docker login (1 failed job, rest didn't run): https://github.com/aws-observability/aws-otel-java-instrumentation/actions/runs/16922512730/job/47951639594
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.