Skip to content

Conversation

@lukeina2z
Copy link
Contributor

@lukeina2z lukeina2z commented Aug 15, 2025

This PR adds a utility method to help migrate deprecated semconv keys. It first checks the new key; if the new key is not available, it falls back to the legacy deprecated key.

This PR also handles the following deprecated keys:

MESSAGING_OPERATION
SERVER_SOCKET_ADDRESS
SERVER_SOCKET_PORT

Tests:
./gradlew build test — Pass
./gradlew appsignals-tests:contract-tests:contractTests — Pass
Manual E2E with Spring Boot sample app: Compared raw span data with and without this change — Pass

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This PR adds a utility method to help migrate deprecated semconv keys.
It first checks the new key; if the new key is not available, it falls back to the legacy deprecated key.

This PR also handles the following deprecated keys:

MESSAGING_OPERATION
SERVER_SOCKET_ADDRESS
SERVER_SOCKET_PORT

Tests:
./gradlew build test — Pass
./gradlew appsignals-tests:contract-tests:contractTests — Pass
Manual E2E with Spring Boot sample app: Compared raw span data with and without this change — Pass
@lukeina2z lukeina2z requested a review from a team as a code owner August 15, 2025 16:30
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.79%. Comparing base (09e6487) to head (6aa2ae8).
⚠️ Report is 462 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #1150       +/-   ##
=============================================
- Coverage     85.71%   67.79%   -17.92%     
- Complexity       19      506      +487     
=============================================
  Files             3       53       +50     
  Lines            49     2599     +2550     
  Branches          5      351      +346     
=============================================
+ Hits             42     1762     +1720     
- Misses            3      711      +708     
- Partials          4      126      +122     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lukeina2z lukeina2z merged commit bb4abb4 into aws-observability:main Aug 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants