fix(deps): Upgrade JDK from 17 to 21 #1157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upstream OTel Java Agent upgraded its build toolchain from JDK 17 to 21 in May 2024. This PR aligns ADOT with that change. Without this upgrade, merges with recent upstream changes will result in build failures. Tests performed: Local build with JDK 21 passes: ./gradlew build Unit tests pass: ./gradlew test Smoke/contract tests pass: ./gradlew appsignals-tests:contract-tests:contractTests
jj22ee
reviewed
Aug 19, 2025
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1157 +/- ##
=============================================
- Coverage 85.71% 67.45% -18.26%
- Complexity 19 521 +502
=============================================
Files 3 54 +51
Lines 49 2649 +2600
Branches 5 368 +363
=============================================
+ Hits 42 1787 +1745
- Misses 3 729 +726
- Partials 4 133 +129 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
thpierce
approved these changes
Aug 20, 2025
Contributor
thpierce
left a comment
thpierce
left a comment
There was a problem hiding this comment.
I think we can only fully validate this by running E2E tests in main build, since they test the produced artifact against all supported versions of Java. Anyways, since the upstream did this already, should be acceptable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream OTel Java Agent upgraded its build toolchain from JDK 17 to 21 in May 2024. This PR aligns ADOT with that change. Without this upgrade, merges with recent upstream changes will result in build failures.
Build with jdk21 #11219
open-telemetry/opentelemetry-java-instrumentation#11219
Tests performed:
Local build with JDK 21 passes: ./gradlew build
Unit tests pass: ./gradlew test
Smoke/contract tests pass: ./gradlew appsignals-tests:contract-tests:contractTests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.