Skip to content

Conversation

@lukeina2z
Copy link
Contributor

ADOT Java was using an outdated Gradle release, particularly the Lambda build (v8.1.1). This PR upgrades both builds to v8.14.3, matching the version used by the upstream Java Agent.

./gradlew wrapper --gradle-version 8.14.3

Tests performed:

  • Local build: ./gradlew build ✅
  • Unit tests: ./gradlew test ✅
  • Smoke/contract tests: ./gradlew appsignals-tests:contract-tests:contractTests ✅

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

ADOT Java was using an outdated Gradle release, particularly the Lambda build (v8.1.1).
This PR upgrades both builds to v8.14.3, matching the version used by the upstream Java Agent.

./gradlew wrapper --gradle-version 8.14.3

Tests performed:
- Local build: ./gradlew build ✅
- Unit tests: ./gradlew test ✅
- Smoke/contract tests: ./gradlew appsignals-tests:contract-tests:contractTests ✅
@lukeina2z lukeina2z requested a review from a team as a code owner August 19, 2025 22:26
@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.79%. Comparing base (09e6487) to head (79cf22e).
⚠️ Report is 467 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #1158       +/-   ##
=============================================
- Coverage     85.71%   67.79%   -17.92%     
- Complexity       19      506      +487     
=============================================
  Files             3       53       +50     
  Lines            49     2599     +2550     
  Branches          5      351      +346     
=============================================
+ Hits             42     1762     +1720     
- Misses            3      711      +708     
- Partials          4      126      +122     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@thpierce thpierce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look reasonable, but it's hard to validate them. Can you describe in the overview HOW you did the upgrade, so I can validate the steps you took? I'm guessing you didn't do all these changes by hand, but used a gradle upgrade guide of some kind?

@lukeina2z
Copy link
Contributor Author

Changes look reasonable, but it's hard to validate them. Can you describe in the overview HOW you did the upgrade, so I can validate the steps you took? I'm guessing you didn't do all these changes by hand, but used a gradle upgrade guide of some kind?

It's generated by using './gradlew wrapper --gradle-version 8.14.3'. It's included in the commit message.

@lukeina2z lukeina2z merged commit 24c2618 into aws-observability:main Aug 20, 2025
7 of 10 checks passed
@lukeina2z lukeina2z deleted the gradle-pr-foo branch August 22, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants