Skip to content

Conversation

@lukeina2z
Copy link
Contributor

@lukeina2z lukeina2z commented Aug 20, 2025

The latest release of gradle/wrapper-validation-action is v3.5, but ADOT Java is currently using v1.

This PR replaces the deprecated gradle/wrapper-validation-action with the new gradle/actions/wrapper-validation action. v4.4.2 is an official release. It's commit hash is #017a9ef.
https://github.com/gradle/actions/releases/tag/v4.4.2

When uses third-party action, we should always use commit hash instead of release number, for security and integrity reason. https://docs.github.com/en/actions/reference/security/secure-use#using-third-party-actions

References:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The latest release of gradle/wrapper-validation-action is v3.5, but ADOT Java is currently using v1.

This PR replaces the deprecated gradle/wrapper-validation-action with the new gradle/actions/wrapper-validation action.

References:
- https://github.com/gradle/wrapper-validation-action
- https://github.com/gradle/actions/releases/
@lukeina2z lukeina2z requested a review from a team as a code owner August 20, 2025 00:53
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.79%. Comparing base (09e6487) to head (1390cca).
⚠️ Report is 468 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #1159       +/-   ##
=============================================
- Coverage     85.71%   67.79%   -17.92%     
- Complexity       19      506      +487     
=============================================
  Files             3       53       +50     
  Lines            49     2599     +2550     
  Branches          5      351      +346     
=============================================
+ Hits             42     1762     +1720     
- Misses            3      711      +708     
- Partials          4      126      +122     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

thpierce
thpierce previously approved these changes Aug 20, 2025
@thpierce thpierce dismissed their stale review August 20, 2025 17:07

Accidentally clicked approve. Want to close on the open question first.

@lukeina2z lukeina2z merged commit 59c9edc into aws-observability:main Aug 20, 2025
5 checks passed
@lukeina2z lukeina2z deleted the gradle-action-pr-foo branch August 22, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants