Skip to content

Propagate sampling decision as attribute #1161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: [Lambda] Remove b3/b3multi propagators (#1174)
merged 1 commit into from
Aug 25, 2025
Merged

Propagate sampling decision as attribute #1161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .../software/amazon/opentelemetry/javaagent/providers/AttributePropagatingSpanProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ public void onStart(Context parentContext, ReadWriteSpan span) {
if (propagationData != null) {
span.setAttribute(propagationDataKey, propagationData);
}
span.setAttribute(AwsAttributeKeys.AWS_TRACE_FLAG_SAMPLED, span.getSpanContext().isSampled());
}

private boolean isConsumerKind(ReadableSpan span) {
Expand Down
3 changes: 0 additions & 3 deletions ...der/src/main/java/software/amazon/opentelemetry/javaagent/providers/AwsAttributeKeys.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,6 @@ private AwsAttributeKeys() {}
static final AttributeKey<Boolean> AWS_TRACE_FLAG_SAMPLED =
AttributeKey.booleanKey("aws.trace.flag.sampled");

static final AttributeKey<String> AWS_XRAY_SAMPLING_RULE =
AttributeKey.stringKey("aws.xray.sampling_rule");

// use the same AWS Resource attribute name defined by OTel java auto-instr for aws_sdk_v_1_1
// TODO: all AWS specific attributes should be defined in semconv package and reused cross all
// otel packages. Related sim -
Expand Down
Loading