[Adaptive Sampling] Ensure sampling rule propagation across AWS accounts #1188
+8
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majanjua-amzn
added
X-Ray
wangzlei
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Changed logic for rule name trace state propagation to ensure in the case that services are in different AWS accounts the root service's applied rule name continues to propagate. This allows for the account to boost effectively if the original AWS account is reached again in a downstream service, e.g. Service A in Acct1 -> Service B in Acct2 -> Service C in Acct1.
Testing
Deployed to demo environment in which all services (A, B, C) are running in an EC2 instance. Created a new sampling rule and restarted services A and C. As the SDK calls GetSamplingRules every 5 minutes, in this 5 minute window service B did not send any statistics to the new sampling rule or to any other but service C was still able to send statistics for boost to service A.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.