Skip to content

Conversation

@majanjua-amzn
Copy link
Contributor

Changes

Adaptive Sampling:

Other changes that were made to handle merge conflicts/build issues:

Testing

  • Validated adaptive sampling functions appropriately, even with a service with faulty propagators placed in between two services using this revision of the SDK (by relying on both baggage and trace state)
  • Added unit tests to assert the statistics generated for GetSamplingTargets for the reimplementation of the parent based sampling statistics

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@majanjua-amzn majanjua-amzn self-assigned this Sep 18, 2025
@majanjua-amzn majanjua-amzn requested a review from a team as a code owner September 18, 2025 23:16
@majanjua-amzn majanjua-amzn added enhancement New feature or request X-Ray AWS X-Ray components traces Tracing related issues java Pull requests that update Java code labels Sep 18, 2025
@majanjua-amzn majanjua-amzn force-pushed the adap-to-main branch 3 times, most recently from 66c7192 to dc7d63f Compare September 18, 2025 23:26
wangzlei
wangzlei previously approved these changes Sep 19, 2025
Copy link
Contributor

@wangzlei wangzlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@majanjua-amzn majanjua-amzn merged commit a4d69a7 into main Sep 22, 2025
6 checks passed
@majanjua-amzn majanjua-amzn deleted the adap-to-main branch September 22, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request java Pull requests that update Java code traces Tracing related issues X-Ray AWS X-Ray components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants