Skip to content

Conversation

@Miqueasher Miqueasher requested a review from a team as a code owner September 19, 2025 16:49
@Miqueasher Miqueasher added the skip changelog doesn't need a CHANGELOG entry label Sep 19, 2025
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.07%. Comparing base (09e6487) to head (da3f142).
⚠️ Report is 506 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #1205       +/-   ##
=============================================
- Coverage     85.71%   67.07%   -18.64%     
- Complexity       19      525      +506     
=============================================
  Files             3       54       +51     
  Lines            49     2694     +2645     
  Branches          5      376      +371     
=============================================
+ Hits             42     1807     +1765     
- Misses            3      750      +747     
- Partials          4      137      +133     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

thpierce
thpierce previously approved these changes Sep 23, 2025
@thpierce thpierce self-requested a review September 23, 2025 18:58
thpierce
thpierce previously approved these changes Sep 23, 2025
Copy link
Contributor

@thpierce thpierce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff since last successful approval workflow run: https://github.com/aws-observability/aws-otel-java-instrumentation/pull/1205/files/2078ea7bc548900d3a0e550f3d1a409963f43d27..fd49dd3e6604e57dd4dd1daad677e86a37557a32

Probably we can safely merge this without waiting for pr-build.

@Miqueasher Miqueasher merged commit d9ed463 into aws-observability:main Sep 23, 2025
7 checks passed
@Miqueasher Miqueasher deleted the vherremi/revertaction branch September 25, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changelog doesn't need a CHANGELOG entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants