Skip to content

Conversation

@thpierce
Copy link
Contributor

Add gate jobs that fail if any workflow job fails OR if any job is missing from the gate's needs array. Prevents both job failures and configuration drift when adding new workflow jobs. Callout: I don't think it's possible to have one gate for both workflows, but it should not be the case that we add more over time.

Testing:

See: aws-observability/aws-otel-python-instrumentation#477

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@thpierce thpierce requested a review from a team as a code owner September 22, 2025 23:06
@thpierce thpierce added the skip changelog doesn't need a CHANGELOG entry label Sep 22, 2025
Copy link
Contributor

@vastin vastin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There is PR build failure but it is unlikely caused by this PR.

@thpierce thpierce merged commit 8ad0b24 into main Sep 23, 2025
10 of 14 checks passed
@thpierce thpierce deleted the thpierce-patch-1 branch September 23, 2025 02:02
jj22ee pushed a commit that referenced this pull request Oct 24, 2025
Add gate jobs that fail if any workflow job fails OR if any job is
missing from the gate's needs array. Prevents both job failures and
configuration drift when adding new workflow jobs. Callout: I don't
think it's possible to have one gate for both workflows, but it should
not be the case that we add more over time.

### Testing:
See:
aws-observability/aws-otel-python-instrumentation#477


By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
jj22ee pushed a commit that referenced this pull request Oct 24, 2025
Add gate jobs that fail if any workflow job fails OR if any job is
missing from the gate's needs array. Prevents both job failures and
configuration drift when adding new workflow jobs. Callout: I don't
think it's possible to have one gate for both workflows, but it should
not be the case that we add more over time.

### Testing:
See:
aws-observability/aws-otel-python-instrumentation#477


By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
jj22ee pushed a commit that referenced this pull request Oct 27, 2025
Add gate jobs that fail if any workflow job fails OR if any job is
missing from the gate's needs array. Prevents both job failures and
configuration drift when adding new workflow jobs. Callout: I don't
think it's possible to have one gate for both workflows, but it should
not be the case that we add more over time.

### Testing:
See:
aws-observability/aws-otel-python-instrumentation#477


By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changelog doesn't need a CHANGELOG entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants