Skip to content

Conversation

liustve
Copy link
Contributor

@liustve liustve commented Oct 3, 2025

Description of changes:
PR builds are failing:
https://github.com/aws-observability/aws-otel-java-instrumentation/actions/runs/18234501009/job/51925394400

    Reason: Task ':smoke-tests:images:quarkus:checkstyleMain' uses this output of task ':smoke-tests:images:quarkus:compileQuarkusGeneratedSourcesJava' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.
    
    Possible solutions:
      1. Declare task ':smoke-tests:images:quarkus:compileQuarkusGeneratedSourcesJava' as an input of ':smoke-tests:images:quarkus:checkstyleMain'.
      2. Declare an explicit dependency on ':smoke-tests:images:quarkus:compileQuarkusGeneratedSourcesJava' from ':smoke-tests:images:quarkus:checkstyleMain' using Task#dependsOn.
      3. Declare an explicit dependency on ':smoke-tests:images:quarkus:compileQuarkusGeneratedSourcesJava' from ':smoke-tests:images:quarkus:checkstyleMain' using Task#mustRunAfter.

This is because the checkstyle task dependency issues where checkstyle uses outputs from compileQuarkusGeneratedSourcesJava without declaring explicit dependencies, causing "implicit dependency" errors. Since we're only testing patch behavior and need functional artifacts published to Maven local, code style validation is unnecessary overhead that can be safely skipped.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@liustve liustve requested a review from a team as a code owner October 3, 2025 22:30
@liustve liustve added the skip changelog doesn't need a CHANGELOG entry label Oct 3, 2025
@liustve liustve changed the title Skip checkstyleMain in Build opentelemetry java instrumentation step Skip checkstyle in Build opentelemetry java instrumentation step Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changelog doesn't need a CHANGELOG entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant