Skip to content

Conversation

@ezhang6811
Copy link
Contributor

@ezhang6811 ezhang6811 commented Oct 14, 2025

Issue #, if available:

Description of changes:
PR builds have been failing for the last 2+ weeks on the Test patches applied to dependencies job: https://github.com/aws-observability/aws-otel-java-instrumentation/actions/runs/18328141549/job/52275908381

This was due to a failing jmx-metrics test in the upstream opentelemetry-java-instrumentation repo that we clone and patch, where several metrics seem to be delayed and thus missing when being verified.

java.lang.AssertionError: Metrics expected but not received: [tomcat.session.active.count, tomcat.session.active.limit]
Received only: [tomcat.network.io, tomcat.thread.busy.count, tomcat.request.duration.sum, tomcat.thread.count, tomcat.request.count, tomcat.error.count, tomcat.thread.limit, tomcat.request.duration.max]

I tried to build the upstream repo standalone on the release/2.18.x branch and got the same issue, confirming that our patches don't affect this. This test seems to depend on a floating tag version of the Tomcat docker image which new changes can be pushed to.

Add a temporary patch fix to skip the old Tomcat 9.0 dependency where the test failure is happening. We can remove this after bumping the opentelemetry-java-instrumentation dependency, as the error is fixed in future versions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ezhang6811 ezhang6811 requested a review from a team as a code owner October 14, 2025 20:18
@ezhang6811 ezhang6811 added the skip changelog doesn't need a CHANGELOG entry label Oct 14, 2025
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.07%. Comparing base (09e6487) to head (e4cb579).
⚠️ Report is 510 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #1239       +/-   ##
=============================================
- Coverage     85.71%   67.07%   -18.64%     
- Complexity       19      525      +506     
=============================================
  Files             3       54       +51     
  Lines            49     2694     +2645     
  Branches          5      376      +371     
=============================================
+ Hits             42     1807     +1765     
- Misses            3      750      +747     
- Partials          4      137      +133     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

thpierce
thpierce previously approved these changes Oct 14, 2025
@ezhang6811 ezhang6811 merged commit 4122805 into aws-observability:main Oct 15, 2025
7 checks passed
@ezhang6811 ezhang6811 deleted the zhaez/fix-pr-build branch October 15, 2025 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changelog doesn't need a CHANGELOG entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants