Fix failing upstream test in PR build #1239
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
PR builds have been failing for the last 2+ weeks on the
Test patches applied to dependenciesjob: https://github.com/aws-observability/aws-otel-java-instrumentation/actions/runs/18328141549/job/52275908381This was due to a failing
jmx-metricstest in the upstream opentelemetry-java-instrumentation repo that we clone and patch, where several metrics seem to be delayed and thus missing when being verified.I tried to build the upstream repo standalone on the release/2.18.x branch and got the same issue, confirming that our patches don't affect this. This test seems to depend on a floating tag version of the Tomcat docker image which new changes can be pushed to.
Add a temporary patch fix to skip the old Tomcat 9.0 dependency where the test failure is happening. We can remove this after bumping the opentelemetry-java-instrumentation dependency, as the error is fixed in future versions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.