Skip to content

Conversation

@ezhang6811
Copy link
Contributor

Issue #, if available:

Description of changes:
The 2.20.0 release build failed with at the step "Build and Publish release with Gradle":

org.gradle.api.GradleException: version should not be set in build file when using nebula-release plugin. Instead use `-Prelease.version` parameter

The following PR fixes version.gradle.kts to not touch project.version at all if the -Prelease.version flag is passed in to an environment. It also creates a copy of the release build workflow that only re-runs the failed Sonatype step in publish-sdk (did 2PR with @jj22ee to confirm).

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ezhang6811 ezhang6811 requested a review from a team as a code owner October 31, 2025 17:10
@ezhang6811 ezhang6811 added the skip changelog doesn't need a CHANGELOG entry label Oct 31, 2025
@wangzlei wangzlei enabled auto-merge (squash) October 31, 2025 17:48
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release/v2.20.x@bd79676). Learn more about missing BASE report.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                Coverage Diff                 @@
##             release/v2.20.x    #1255   +/-   ##
==================================================
  Coverage                   ?   67.28%           
  Complexity                 ?      525           
==================================================
  Files                      ?       54           
  Lines                      ?     2693           
  Branches                   ?      373           
==================================================
  Hits                       ?     1812           
  Misses                     ?      746           
  Partials                   ?      135           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wangzlei wangzlei merged commit 5552646 into aws-observability:release/v2.20.x Oct 31, 2025
9 of 12 checks passed
@ezhang6811 ezhang6811 deleted the release-patch branch October 31, 2025 19:52
ezhang6811 added a commit that referenced this pull request Nov 4, 2025
*Issue #, if available:*

*Description of changes:*
cherry-picks commit from #1255, see for more details.

Do not touch the version variable in environments where
`-Prelease.version` is passed in. This prevents a versioning conflict in
`closeAndReleaseSonatypeStagingRepository`, an error which was only
thrown when releasing.

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
ezhang6811 added a commit that referenced this pull request Nov 4, 2025
*Issue #, if available:*

*Description of changes:*
In #1255, after making a fix to the version file, we re-ran the workflow
with the already-successful "Build and push image" step commented out.
This PR uncomments the step again for future patch releases on the
v2.20.x branch.

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changelog doesn't need a CHANGELOG entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants