Add Application Signals E2E Test Coverage #897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrryr
force-pushed
the
add-application-signals-e2e-test-coverage
branch
9 times, most recently
from
185e026 to
b1a7835
Compare
harrryr
force-pushed
the
add-application-signals-e2e-test-coverage
branch
from
b1a7835 to
d044370
Compare
majanjua-amzn
previously approved these changes
Oct 3, 2024
Contributor
majanjua-amzn
left a comment
majanjua-amzn
left a comment
There was a problem hiding this comment.
Looks good! Nits are just asking to shorten job names and clarify metric limiter use case. Not blocking
harrryr
force-pushed
the
add-application-signals-e2e-test-coverage
branch
from
d082e2e to
3e22e39
Compare
majanjua-amzn
approved these changes
Oct 4, 2024
mxiamxia
approved these changes
Oct 4, 2024
musa-asad
pushed a commit
to musa-asad/aws-otel-java-instrumentation
that referenced
this pull request
Oct 8, 2024
*Issue #, if available:* We currently do not have full test coverage over our ADOT artifacts. We need to ensure that ADOT is compatible with Java versions, CPU architecture and different platforms before we release them. *Description of changes:* - Adding language version tests for Java 8, 17, 21, 22 - Adding CPU architecture test for ARM64 Java 8 currently does not work because the /mysql test case has a bug. Will follow up on fixing it in another PR Test run: Test run for EKS: https://github.com/aws-observability/aws-otel-java-instrumentation/actions/runs/11149306942 Test run for rest: https://github.com/aws-observability/aws-otel-java-instrumentation/actions/runs/11148995161 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
We currently do not have full test coverage over our ADOT artifacts. We need to ensure that ADOT is compatible with Java versions, CPU architecture and different platforms before we release them.
Description of changes:
Java 8 currently does not work because the /mysql test case has a bug. Will follow up on fixing it in another PR
Test run:
Test run for EKS: https://github.com/aws-observability/aws-otel-java-instrumentation/actions/runs/11149306942
Test run for rest: https://github.com/aws-observability/aws-otel-java-instrumentation/actions/runs/11148995161
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.