-
Notifications
You must be signed in to change notification settings - Fork 64
Adding UdpExporter for Otlp spans #944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
0a778c1
Adding UdpExporter for Otlp spans
srprash 68fc80c
Unit tests + cleanup
srprash 1555fc6
javadocs, deps and class restrictions, unit tests
srprash 589c163
refactoring the builder and exporter classes
srprash 2a6838e
Merge branch 'main' into main
srprash 4dc14b6
check socket for nullness before sending data
srprash File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
97 changes: 97 additions & 0 deletions
97
.../src/main/java/software/amazon/opentelemetry/javaagent/providers/OtlpUdpSpanExporter.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,97 @@ | ||
/* | ||
* Copyright Amazon.com, Inc. or its affiliates. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"). | ||
* You may not use this file except in compliance with the License. | ||
* A copy of the License is located at | ||
* | ||
* http://aws.amazon.com/apache2.0 | ||
* | ||
* or in the "license" file accompanying this file. This file is distributed | ||
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
* express or implied. See the License for the specific language governing | ||
* permissions and limitations under the License. | ||
*/ | ||
|
||
package software.amazon.opentelemetry.javaagent.providers; | ||
|
||
import io.opentelemetry.exporter.internal.otlp.traces.TraceRequestMarshaler; | ||
import io.opentelemetry.sdk.common.CompletableResultCode; | ||
import io.opentelemetry.sdk.trace.data.SpanData; | ||
import io.opentelemetry.sdk.trace.export.SpanExporter; | ||
import java.io.ByteArrayOutputStream; | ||
import java.nio.charset.StandardCharsets; | ||
import java.util.Base64; | ||
import java.util.Collection; | ||
import java.util.concurrent.atomic.AtomicBoolean; | ||
import java.util.logging.Level; | ||
import java.util.logging.Logger; | ||
import javax.annotation.concurrent.Immutable; | ||
|
||
/** | ||
* Exports spans via UDP, using OpenTelemetry's protobuf model. The protobuf modelled spans are | ||
* Base64 encoded and prefixed with AWS X-Ray specific information before being sent over to {@link | ||
* UdpSender}. | ||
* | ||
* <p>This exporter is NOT meant for generic use since the payload is prefixed with AWS X-Ray | ||
* specific information. | ||
*/ | ||
@Immutable | ||
class OtlpUdpSpanExporter implements SpanExporter { | ||
|
||
private static final Logger logger = Logger.getLogger(OtlpUdpSpanExporter.class.getName()); | ||
|
||
private final AtomicBoolean isShutdown = new AtomicBoolean(); | ||
|
||
private final UdpSender sender; | ||
private final String payloadPrefix; | ||
|
||
OtlpUdpSpanExporter(UdpSender sender, String payloadPrefix) { | ||
this.sender = sender; | ||
this.payloadPrefix = payloadPrefix; | ||
} | ||
|
||
@Override | ||
public CompletableResultCode export(Collection<SpanData> spans) { | ||
if (isShutdown.get()) { | ||
return CompletableResultCode.ofFailure(); | ||
} | ||
|
||
TraceRequestMarshaler exportRequest = TraceRequestMarshaler.create(spans); | ||
ByteArrayOutputStream baos = new ByteArrayOutputStream(); | ||
try { | ||
exportRequest.writeBinaryTo(baos); | ||
String payload = payloadPrefix + Base64.getEncoder().encodeToString(baos.toByteArray()); | ||
sender.send(payload.getBytes(StandardCharsets.UTF_8)); | ||
return CompletableResultCode.ofSuccess(); | ||
} catch (Exception e) { | ||
logger.log(Level.SEVERE, "Failed to export spans. Error: " + e.getMessage(), e); | ||
return CompletableResultCode.ofFailure(); | ||
} | ||
} | ||
|
||
@Override | ||
public CompletableResultCode flush() { | ||
// TODO: implement | ||
return CompletableResultCode.ofSuccess(); | ||
} | ||
|
||
@Override | ||
public CompletableResultCode shutdown() { | ||
if (!isShutdown.compareAndSet(false, true)) { | ||
logger.log(Level.INFO, "Calling shutdown() multiple times."); | ||
return CompletableResultCode.ofSuccess(); | ||
} | ||
return sender.shutdown(); | ||
} | ||
|
||
// Visible for testing | ||
UdpSender getSender() { | ||
return sender; | ||
} | ||
|
||
// Visible for testing | ||
String getPayloadPrefix() { | ||
return payloadPrefix; | ||
} | ||
} |
77 changes: 77 additions & 0 deletions
77
...in/java/software/amazon/opentelemetry/javaagent/providers/OtlpUdpSpanExporterBuilder.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,77 @@ | ||
/* | ||
* Copyright Amazon.com, Inc. or its affiliates. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"). | ||
* You may not use this file except in compliance with the License. | ||
* A copy of the License is located at | ||
* | ||
* http://aws.amazon.com/apache2.0 | ||
* | ||
* or in the "license" file accompanying this file. This file is distributed | ||
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
* express or implied. See the License for the specific language governing | ||
* permissions and limitations under the License. | ||
*/ | ||
|
||
package software.amazon.opentelemetry.javaagent.providers; | ||
|
||
import static java.util.Objects.requireNonNull; | ||
|
||
final class OtlpUdpSpanExporterBuilder { | ||
|
||
private static final String DEFAULT_HOST = "127.0.0.1"; | ||
private static final int DEFAULT_PORT = 2000; | ||
|
||
// The protocol header and delimiter is required for sending data to X-Ray Daemon or when running | ||
// in Lambda. | ||
// https://docs.aws.amazon.com/xray/latest/devguide/xray-api-sendingdata.html#xray-api-daemon | ||
private static final String PROTOCOL_HEADER = "{\"format\": \"json\", \"version\": 1}"; | ||
private static final char PROTOCOL_DELIMITER = '\n'; | ||
|
||
// These prefixes help the backend identify if the spans payload is sampled or not. | ||
private static final String FORMAT_OTEL_SAMPLED_TRACES_BINARY_PREFIX = "T1S"; | ||
private static final String FORMAT_OTEL_UNSAMPLED_TRACES_BINARY_PREFIX = "T1U"; | ||
|
||
private UdpSender sender; | ||
private String tracePayloadPrefix = FORMAT_OTEL_SAMPLED_TRACES_BINARY_PREFIX; | ||
|
||
public OtlpUdpSpanExporterBuilder setEndpoint(String endpoint) { | ||
requireNonNull(endpoint, "endpoint must not be null"); | ||
try { | ||
String[] parts = endpoint.split(":"); | ||
String host = parts[0]; | ||
int port = Integer.parseInt(parts[1]); | ||
this.sender = new UdpSender(host, port); | ||
} catch (Exception e) { | ||
throw new IllegalArgumentException("Invalid endpoint, must be a valid URL: " + endpoint, e); | ||
} | ||
return this; | ||
} | ||
|
||
public OtlpUdpSpanExporterBuilder setPayloadSampleDecision(TracePayloadSampleDecision decision) { | ||
this.tracePayloadPrefix = | ||
decision == TracePayloadSampleDecision.SAMPLED | ||
? FORMAT_OTEL_SAMPLED_TRACES_BINARY_PREFIX | ||
: FORMAT_OTEL_UNSAMPLED_TRACES_BINARY_PREFIX; | ||
return this; | ||
} | ||
|
||
public OtlpUdpSpanExporter build() { | ||
if (sender == null) { | ||
this.sender = new UdpSender(DEFAULT_HOST, DEFAULT_PORT); | ||
} | ||
return new OtlpUdpSpanExporter( | ||
this.sender, PROTOCOL_HEADER + PROTOCOL_DELIMITER + tracePayloadPrefix); | ||
} | ||
|
||
// Only for testing | ||
OtlpUdpSpanExporterBuilder setSender(UdpSender sender) { | ||
this.sender = sender; | ||
return this; | ||
} | ||
} | ||
|
||
enum TracePayloadSampleDecision { | ||
SAMPLED, | ||
UNSAMPLED | ||
} |
76 changes: 76 additions & 0 deletions
76
...ntprovider/src/main/java/software/amazon/opentelemetry/javaagent/providers/UdpSender.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,76 @@ | ||
/* | ||
* Copyright Amazon.com, Inc. or its affiliates. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"). | ||
* You may not use this file except in compliance with the License. | ||
* A copy of the License is located at | ||
* | ||
* http://aws.amazon.com/apache2.0 | ||
* | ||
* or in the "license" file accompanying this file. This file is distributed | ||
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
* express or implied. See the License for the specific language governing | ||
* permissions and limitations under the License. | ||
*/ | ||
|
||
package software.amazon.opentelemetry.javaagent.providers; | ||
|
||
import io.opentelemetry.sdk.common.CompletableResultCode; | ||
import java.io.IOException; | ||
import java.net.DatagramPacket; | ||
import java.net.DatagramSocket; | ||
import java.net.InetSocketAddress; | ||
import java.net.SocketException; | ||
import java.util.logging.Level; | ||
import java.util.logging.Logger; | ||
|
||
/** | ||
* This class represents a UDP sender that sends data to a specified endpoint. It is used to send | ||
* data to a remote host and port using UDP protocol. | ||
*/ | ||
class UdpSender { | ||
private static final Logger logger = Logger.getLogger(UdpSender.class.getName()); | ||
|
||
private DatagramSocket socket; | ||
private final InetSocketAddress endpoint; | ||
|
||
public UdpSender(String host, int port) { | ||
this.endpoint = new InetSocketAddress(host, port); | ||
try { | ||
this.socket = new DatagramSocket(); | ||
} catch (SocketException e) { | ||
logger.log(Level.SEVERE, "Exception while instantiating UdpSender socket.", e); | ||
} | ||
} | ||
|
||
public CompletableResultCode shutdown() { | ||
try { | ||
if (socket == null) { | ||
return CompletableResultCode.ofSuccess(); | ||
} | ||
socket.close(); | ||
return CompletableResultCode.ofSuccess(); | ||
} catch (Exception e) { | ||
logger.log(Level.SEVERE, "Exception while closing UdpSender socket.", e); | ||
return CompletableResultCode.ofFailure(); | ||
} | ||
} | ||
|
||
public void send(byte[] data) { | ||
if (socket == null) { | ||
logger.log(Level.WARNING, "UdpSender socket is null. Cannot send data."); | ||
return; | ||
} | ||
DatagramPacket packet = new DatagramPacket(data, data.length, endpoint); | ||
try { | ||
socket.send(packet); | ||
srprash marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} catch (IOException e) { | ||
logger.log(Level.SEVERE, "Exception while sending data.", e); | ||
} | ||
} | ||
|
||
// Visible for testing | ||
InetSocketAddress getEndpoint() { | ||
return endpoint; | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.