Migrate logging to debug exporter to match with latest otel colletor. #979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxaws
previously approved these changes
Dec 19, 2024
pxaws
approved these changes
Dec 19, 2024
zzhlogin
changed the title
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #979 +/- ##
=============================================
- Coverage 85.71% 69.45% -16.27%
- Complexity 19 322 +303
=============================================
Files 3 26 +23
Lines 49 1172 +1123
Branches 5 165 +160
=============================================
+ Hits 42 814 +772
- Misses 3 304 +301
- Partials 4 54 +50 ☔ View full report in Codecov by Sentry. |
This was referenced Dec 23, 2024
srprash
pushed a commit
that referenced
this pull request
Dec 24, 2024
…#984) *Description of changes:* The previous [ADOT Java main build failed](https://github.com/aws-observability/aws-otel-java-instrumentation/actions/runs/12421612708) because of it is using the collector version v0.42.0 released 8 hours ago, where the logging exporter has been deprecated. This PR migrate to debug exporter according to: open-telemetry/opentelemetry-collector#11337. Also, add a step in PR build to clean up the storage to avoid "No space left in the device" failure. Same fix has been applied to v2.x branch: #979 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Change back to use java 17 base image.
The previous ADOT Java main build failed because of it is using the collector version v0.42.0 released 8 hours ago, where the logging exporter has been deprecated. This PR migrate to debug exporter according to:
open-telemetry/opentelemetry-collector#11337.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.