Enable smoke test controller telemetry. #985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srprash
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Previously, in v1.x, the springboot controller telemetry data is enabled by default.
Starting from upstream v2.x, the controller telemetry need to be enable by setting up env
OTEL_INSTRUMENTATION_COMMON_EXPERIMENTAL_CONTROLLER_TELEMETRY_ENABLED: https://opentelemetry.io/docs/zero-code/java/agent/disable/#suppressing-controller-andor-view-spans.This PR enable the telemetry data to align with smoke test validator.
https://opentelemetry.io/docs/zero-code/java/agent/disable/#suppressing-controller-andor-view-spans
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.