Skip to content

Update Lambda local.operation name #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Update Lambda local.operation name #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion aws-distro-opentelemetry-node-autoinstrumentation/src/aws-span-processing-util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export class AwsSpanProcessingUtil {
operation = AwsSpanProcessingUtil.INTERNAL_OPERATION;
}
if (isLambdaEnvironment()) {
operation = process.env[AWS_LAMBDA_FUNCTION_NAME_CONFIG] + '/Handler';
operation = process.env[AWS_LAMBDA_FUNCTION_NAME_CONFIG] + '/FunctionHandler';
} else if (!AwsSpanProcessingUtil.isValidOperation(span, operation)) {
operation = AwsSpanProcessingUtil.generateIngressOperation(span);
}
Expand Down
2 changes: 1 addition & 1 deletion aws-distro-opentelemetry-node-autoinstrumentation/test/aws-span-processing-util.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ describe('AwsSpanProcessingUtilTest', () => {
(spanDataMock as any).name = validName;
(spanDataMock as any).kind = SpanKind.SERVER;
const actualOperation: string = AwsSpanProcessingUtil.getIngressOperation(spanDataMock);
expect(actualOperation).toEqual('TestFunction/Handler');
expect(actualOperation).toEqual('TestFunction/FunctionHandler');
});

it('should return cloud.resource_id when present', () => {
Expand Down
2 changes: 1 addition & 1 deletion lambda-layer/terraform/lambda/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,5 +64,5 @@ resource "aws_iam_role_policy_attachment" "hello-lambda-cloudwatch" {

resource "aws_iam_role_policy_attachment" "test_xray" {
role = module.hello-lambda-function.lambda_function_name
policy_arn = "arn:aws:iam::aws:policy/AWSXRayDaemonWriteAccess"
policy_arn = "arn:aws:iam::aws:policy/CloudWatchLambdaApplicationSignalsExecutionRolePolicy"
}
Loading