SigV4 Authentication support for http/protobuf exporter #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
aws-distro-opentelemetry-node-autoinstrumentation/src/aws-opentelemetry-configurator.ts
Fixed
Show fixed
Hide fixed
Contributor
majanjua-amzn
left a comment
majanjua-amzn
left a comment
There was a problem hiding this comment.
Great work, let's also add some tests here like in the other languages
aws-distro-opentelemetry-node-autoinstrumentation/src/aws-opentelemetry-configurator.ts
Outdated
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/src/otlp-aws-span-exporter.ts
Outdated
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/src/otlp-aws-span-exporter.ts
Outdated
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/src/otlp-aws-span-exporter.ts
Outdated
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/src/otlp-aws-span-exporter.ts
Outdated
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/src/aws-opentelemetry-configurator.ts
Fixed
Show fixed
Hide fixed
aws-distro-opentelemetry-node-autoinstrumentation/src/aws-opentelemetry-configurator.ts
Fixed
Show fixed
Hide fixed
aws-distro-opentelemetry-node-autoinstrumentation/src/aws-opentelemetry-configurator.ts
Fixed
Show fixed
Hide fixed
aws-distro-opentelemetry-node-autoinstrumentation/src/aws-opentelemetry-configurator.ts
Fixed
Show fixed
Hide fixed
aws-distro-opentelemetry-node-autoinstrumentation/src/aws-opentelemetry-configurator.ts
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/src/otlp-aws-span-exporter.ts
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/test/otlp-aws-span-exporter.test.ts
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/test/otlp-aws-span-exporter.test.ts
Show resolved
Hide resolved
majanjua-amzn
previously approved these changes
Feb 25, 2025
wangzlei
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Adding SigV4 Authentication extension for Exporting traces to OTLP XRay endpoint without needing to explictily install the collector.
Description of changes:
Added a new class that extends upstream's OTLP http/protobuf span exporter. Overrides the export method so that if the endpoint is CW, we add an extra step of injecting SigV4 authentication to the headers.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.