Refactor Lambda Layer bundling #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jj22ee
reviewed
Apr 2, 2025
Contributor
jj22ee
left a comment
jj22ee
left a comment
There was a problem hiding this comment.
Changes look good.
Can you list out which of these files are directly copied/modified from OTel's solution, and can you add images of the Trace map for both CJS and ESM Lambda handlers?
Contributor
Author
Description updated. I went back and removed the loader scripts since they weren't needed to instrument either handler. |
jj22ee
previously approved these changes
Apr 4, 2025
mxiamxia
reviewed
Apr 4, 2025
mxiamxia
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
#171 introduced a bug where the Lambda server span was no longer produced in trace map for ESM-based handlers. This PR fixes the bug and now bundles the lambda layer directly instead of the autoinstrumentation package. The size of the bundled layer is now ~920KB, a nearly 94% reduction in size from the original 14.5MB.
The following files were copied from upstream to support Lambda layer bundling with minor changes:
webpack.config.js,tsconfig.webpack.json,tsconfig.esm.json, andinstall-externals.sh.Trace Map for CJS handler:
Trace Map for ESM handler:
Trace Map for ESM handler prior to fix (with bug):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.