feat: Extract resource arn and remote resource access key for cross-account support #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jj22ee
reviewed
Jun 23, 2025
aws-distro-opentelemetry-node-autoinstrumentation/src/patches/instrumentation-patch.ts
Outdated
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/src/patches/instrumentation-patch.ts
Outdated
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/src/patches/instrumentation-patch.ts
Outdated
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/src/patches/instrumentation-patch.ts
Outdated
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/src/patches/instrumentation-patch.ts
Outdated
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/src/regional-resource-arn-parser.ts
Outdated
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/src/regional-resource-arn-parser.ts
Outdated
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/src/sqs-url-parser.ts
Outdated
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/src/aws-metric-attribute-generator.ts
Outdated
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/src/aws-attribute-keys.ts
Outdated
Show resolved
Hide resolved
jj22ee
reviewed
Jul 2, 2025
aws-distro-opentelemetry-node-autoinstrumentation/src/patches/instrumentation-patch.ts
Outdated
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/src/aws-metric-attribute-generator.ts
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/src/regional-resource-arn-parser.ts
Outdated
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/test/aws-metric-attribute-generator.test.ts
Outdated
Show resolved
Hide resolved
bjrara
approved these changes
Jul 3, 2025
jj22ee
added a commit
to jj22ee/aws-otel-js-instrumentation
that referenced
this pull request
Jul 11, 2025
… cross-account support (aws-observability#192)" This reverts commit 9b0a538.
jj22ee
added a commit
that referenced
this pull request
Jul 11, 2025
… cross-account support (#192)" (#212) *Issue #, if available:* This reverts commit 9b0a538 (#192). This is a temporary change in order to unblock the main build workflow that is currently failing - https://github.com/aws-observability/aws-otel-js-instrumentation/actions/runs/16062476677/job/45752418669 *Description of changes:* By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
blairhyy-amazon
pushed a commit
to blairhyy-amazon/aws-otel-js-instrumentation
that referenced
this pull request
Jul 22, 2025
… key for cross-account support (aws-observability#192)"" This reverts commit d2a69eb.
blairhyy-amazon
added a commit
to blairhyy-amazon/aws-otel-js-instrumentation
that referenced
this pull request
Jul 22, 2025
…ccount support (aws-observability#192) **Description of changes:** 1. Add auto-instrumentation support for the following AWS resources. - Populate `aws.stream.arn` in Span by extracting StreamArn from the request body. - Populate `aws.table.arn` in Span by extracting TableArn from the response body. 2. Add auto-instrumentation support for remote resource access key. - Populate `aws.auth.account.access_key` and `aws.auth.region` in Span from STS credentials in client config 3. Generate cross-account metrics attributes when remote resource identifier is present - If remote resource arn is available, extract account id and region from arn. - Otherwise, pass account access key id and region from span to metric if available. 4. Add unit tests, contract tests. Done E2E tests with CW agent. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
blairhyy-amazon
added a commit
to blairhyy-amazon/aws-otel-js-instrumentation
that referenced
this pull request
Jul 29, 2025
…ccount support (aws-observability#192) **Description of changes:** 1. Add auto-instrumentation support for the following AWS resources. - Populate `aws.stream.arn` in Span by extracting StreamArn from the request body. - Populate `aws.table.arn` in Span by extracting TableArn from the response body. 2. Add auto-instrumentation support for remote resource access key. - Populate `aws.auth.account.access_key` and `aws.auth.region` in Span from STS credentials in client config 3. Generate cross-account metrics attributes when remote resource identifier is present - If remote resource arn is available, extract account id and region from arn. - Otherwise, pass account access key id and region from span to metric if available. 4. Add unit tests, contract tests. Done E2E tests with CW agent. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
aws.stream.arnin Span by extracting StreamArn from the request body.aws.table.arnin Span by extracting TableArn from the response body.aws.auth.account.access_keyandaws.auth.regionin Span from STS credentials in client configBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.