Skip to content

Conversation

@ezhang6811
Copy link
Contributor

@ezhang6811 ezhang6811 commented Oct 23, 2025

Issue #, if available:

Description of changes:
Release workflow failed with

4.633 error: failed to compile `cargo-audit v0.21.2`, intermediate artifacts can be found at `/tmp/cargo-installmLFMlZ`.
4.633 To reuse those artifacts with a future compilation, set the environment variable `CARGO_TARGET_DIR` to that path.
4.633 
4.633 Caused by:
4.633   rustc 1.87.0 is not supported by the following package:
4.633     [email protected] requires rustc 1.89
4.633   Try re-running `cargo install` with `--locked`

Fix by using cargo install cargo-audit --locked to resolve dependencies using the constraints defined in Cargo.lock.

Tested this locally by running docker build --platform linux/amd64 -t test-adot-js . without and with the change, confirmed that the latter works.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ezhang6811 ezhang6811 requested a review from a team as a code owner October 23, 2025 22:25
@ezhang6811 ezhang6811 added the skip changelog doesn't need a CHANGELOG entry label Oct 23, 2025
@thpierce
Copy link
Contributor

Why do we feel --locked is correct? What exactly does it "lock"?

ezhang6811 added a commit that referenced this pull request Oct 24, 2025
*Issue #, if available:*

*Description of changes:*
see
#285

By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.
ezhang6811 added a commit to aws-observability/aws-otel-java-instrumentation that referenced this pull request Oct 24, 2025
*Issue #, if available:*

*Description of changes:*
see
aws-observability/aws-otel-js-instrumentation#285

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
@ezhang6811 ezhang6811 merged commit b550c43 into aws-observability:release/v0.8.x Oct 24, 2025
19 of 21 checks passed
@ezhang6811 ezhang6811 deleted the dockerfile-patch branch October 24, 2025 17:10
jj22ee pushed a commit to aws-observability/aws-otel-java-instrumentation that referenced this pull request Oct 24, 2025
*Issue #, if available:*

*Description of changes:*
see
aws-observability/aws-otel-js-instrumentation#285

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
jj22ee pushed a commit to aws-observability/aws-otel-java-instrumentation that referenced this pull request Oct 27, 2025
*Issue #, if available:*

*Description of changes:*
see
aws-observability/aws-otel-js-instrumentation#285

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changelog doesn't need a CHANGELOG entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants