fix: Recognize OTEL_EXPORTER_OTLP_ENDPOINT as custom endpoint in Lambda environment
#298
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #297
Solution
Updated
hasCustomOtlpTraceEndpoint()to also check for the genericOTEL_EXPORTER_OTLP_ENDPOINTenvironment variable, per the OpenTelemetry OTLP Exporter specification:Changes
aws-distro-opentelemetry-node-autoinstrumentation/src/aws-opentelemetry-configurator.ts: UpdatedhasCustomOtlpTraceEndpoint()to recognize bothOTEL_EXPORTER_OTLP_TRACES_ENDPOINTandOTEL_EXPORTER_OTLP_ENDPOINTas custom endpoints.aws-distro-opentelemetry-node-autoinstrumentation/test/aws-opentelemetry-configurator.test.ts: Added test case to verify that settingOTEL_EXPORTER_OTLP_ENDPOINTin Lambda environment uses OTLP exporter instead of UDP.