[Logs] Workaround to avoid unwanted OTel log when OTEL_TRACES_SAMPLER = xray
#81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Short-term workaround to avoid Upsteam OTel emitting logs such as:
OTEL_TRACES_SAMPLER value "xray invalid, defaulting to always_on".OTel dependencies will always load a default Sampler configuration. Although unused, that load process will read the
OTEL_TRACES_SAMPLERvalue and may emit the above log, which is unwanted forxrayvalue.xraydoes not yet exist in upstream OTel, but in ADOT, we define it as valid. Thus we temporarily remove this env var to avoid the unwanted log only ifxrayis set in that Env Var.When
xraysampler is available in upstream, this workaround should be removed.Description of changes:
process.env.OTEL_TRACES_SAMPLERif equal toxray, then use boolean variable to enablexraysampler instead of Env Var. Restore Env Var value later.AWS XRay Sampler enabled, if enabledTesting:
OTEL_TRACES_SAMPLER value "xray invalid, defaulting to always_on".doesn't appear in this repo's sample app.Before:
After:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.