Skip to content

Conversation

@vasireddy99
Copy link
Contributor

@vasireddy99 vasireddy99 commented Dec 31, 2024

Description:

This PR updates the scripts and make more changes w/r/t to the breaking changes after sub module update

Users (of tracer layers that have implemented xray-lambda) that send traces to X-Ray, especially if they enable Active Tracing, should override this value to OTEL_PROPAGATORS=tracecontext,baggage,xray-lambda to ensure proper span relationships within X-Ray.

  • set otel propagators in the scriptsref here
  • expands nodejs runtimes for collector layer in the tf files to be inline with supported lambda runtimes
  • Update go sample build script to add go mod tidy to fix the inconsistent go mod file upstream.
  • Logging exporter is deprecated, use debug exporter in the configuration.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vasireddy99 vasireddy99 requested a review from a team as a code owner December 31, 2024 00:59
Copy link
Member

@Aneurysm9 Aneurysm9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR seems to be doing more than it says and it's not clear why.

# Build sample app

cd ../opentelemetry-lambda/go/sample-apps/function || exit
go mod tidy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be necessary. The repo shouldn't ever be left in a state where the go.mod file is inconsistent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i agree, created the PR, i will remove this line once the upstream pr is merged.

@vasireddy99 vasireddy99 changed the title Set/modify otel propagators in the build scripts Fix workflows with breaking changes and Set/modify otel propagators in the build scripts Dec 31, 2024
@vasireddy99
Copy link
Contributor Author

This PR seems to be doing more than it says and it's not clear why.

I have updated the description related to the changes.

@vasireddy99 vasireddy99 changed the title Fix workflows with breaking changes and Set/modify otel propagators in the build scripts [chore] Fix workflows with breaking changes and Set/modify otel propagators in the build scripts Dec 31, 2024
@vasireddy99 vasireddy99 merged commit 7f26d89 into aws-observability:main Jan 2, 2025
14 checks passed
@vasireddy99 vasireddy99 deleted the fixworkflow branch January 2, 2025 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants