Skip to content

Commit 43db35e

Browse files
Remove is_lambda tests and assertions from EMF exporter tests
- Remove test_is_lambda_initialization from test_aws_cloudwatch_emf_exporter.py - Remove test_is_lambda_initialization from test_console_emf_exporter.py - Remove is_lambda parameter assertions from test_aws_opentelementry_configurator.py 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent 52ffbd3 commit 43db35e

File tree

3 files changed

+2
-49
lines changed

3 files changed

+2
-49
lines changed

aws-opentelemetry-distro/tests/amazon/opentelemetry/distro/exporter/aws/metrics/test_aws_cloudwatch_emf_exporter.py

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -161,32 +161,6 @@ def test_initialization_with_custom_params(self, mock_session):
161161
self.assertEqual(exporter.namespace, "CustomNamespace")
162162
self.assertEqual(exporter.log_group_name, "custom-log-group")
163163

164-
@patch("botocore.session.Session")
165-
def test_is_lambda_initialization(self, mock_session):
166-
"""Test exporter initialization with is_lambda parameter."""
167-
# Mock the botocore session to avoid AWS calls
168-
mock_client = Mock()
169-
mock_session_instance = Mock()
170-
mock_session.return_value = mock_session_instance
171-
mock_session_instance.create_client.return_value = mock_client
172-
173-
# Test with is_lambda=True
174-
exporter_lambda = AwsCloudWatchEmfExporter(
175-
session=mock_session_instance,
176-
namespace="TestNamespace",
177-
log_group_name="test-log-group",
178-
is_lambda=True,
179-
)
180-
self.assertTrue(exporter_lambda._is_lambda)
181-
182-
# Test with is_lambda=False (default)
183-
exporter_non_lambda = AwsCloudWatchEmfExporter(
184-
session=mock_session_instance,
185-
namespace="TestNamespace",
186-
log_group_name="test-log-group",
187-
)
188-
self.assertFalse(exporter_non_lambda._is_lambda)
189-
190164
def test_get_unit_mapping(self):
191165
"""Test unit mapping functionality."""
192166
# Test known units from UNIT_MAPPING

aws-opentelemetry-distro/tests/amazon/opentelemetry/distro/exporter/aws/metrics/test_console_emf_exporter.py

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -52,25 +52,6 @@ def test_initialization_with_parameters(self):
5252
exporter = ConsoleEmfExporter(namespace="TestNamespace", extra_param="ignored") # Should be ignored
5353
self.assertEqual(exporter.namespace, "TestNamespace")
5454

55-
def test_is_lambda_initialization(self):
56-
"""Test is_lambda parameter initialization."""
57-
# Default should be False
58-
exporter = ConsoleEmfExporter()
59-
self.assertFalse(exporter._is_lambda)
60-
61-
# Explicit False
62-
exporter = ConsoleEmfExporter(is_lambda=False)
63-
self.assertFalse(exporter._is_lambda)
64-
65-
# Explicit True
66-
exporter = ConsoleEmfExporter(is_lambda=True)
67-
self.assertTrue(exporter._is_lambda)
68-
69-
# With other parameters
70-
exporter = ConsoleEmfExporter(namespace="TestNamespace", is_lambda=True)
71-
self.assertEqual(exporter.namespace, "TestNamespace")
72-
self.assertTrue(exporter._is_lambda)
73-
7455
def test_export_log_event_success(self):
7556
"""Test that log events are properly sent to console output."""
7657
# Create a simple log event with EMF-formatted message

aws-opentelemetry-distro/tests/amazon/opentelemetry/distro/test_aws_opentelementry_configurator.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1327,7 +1327,7 @@ def test_create_emf_exporter_lambda_without_valid_headers(
13271327
result = _create_emf_exporter()
13281328

13291329
self.assertEqual(result, mock_exporter_instance)
1330-
mock_console_exporter.assert_called_once_with(namespace="test-namespace", is_lambda=True)
1330+
mock_console_exporter.assert_called_once_with(namespace="test-namespace")
13311331

13321332
@patch("amazon.opentelemetry.distro.aws_opentelemetry_configurator._fetch_logs_header")
13331333
@patch("amazon.opentelemetry.distro.aws_opentelemetry_configurator._is_lambda_environment")
@@ -1360,7 +1360,6 @@ def test_create_emf_exporter_lambda_with_valid_headers(self, mock_get_session, m
13601360
namespace="test-namespace",
13611361
log_group_name="test-group",
13621362
log_stream_name="test-stream",
1363-
is_lambda=True,
13641363
)
13651364

13661365
@patch("amazon.opentelemetry.distro.aws_opentelemetry_configurator._fetch_logs_header")
@@ -1396,7 +1395,6 @@ def test_create_emf_exporter_non_lambda_with_valid_headers(
13961395
namespace="test-namespace",
13971396
log_group_name="test-group",
13981397
log_stream_name="test-stream",
1399-
is_lambda=False,
14001398
)
14011399

14021400
@patch("amazon.opentelemetry.distro.aws_opentelemetry_configurator._fetch_logs_header")
@@ -1476,7 +1474,7 @@ def test_create_emf_exporter_lambda_without_valid_headers_none_namespace(
14761474
result = _create_emf_exporter()
14771475

14781476
self.assertEqual(result, mock_exporter_instance)
1479-
mock_console_exporter.assert_called_once_with(namespace=None, is_lambda=True)
1477+
mock_console_exporter.assert_called_once_with(namespace=None)
14801478

14811479
@patch("amazon.opentelemetry.distro.aws_opentelemetry_configurator._fetch_logs_header")
14821480
@patch("amazon.opentelemetry.distro.aws_opentelemetry_configurator._is_lambda_environment")

0 commit comments

Comments
 (0)