Skip to content

Commit d0ebc15

Browse files
committed
Merge branch 'genai_logs' into sigv4_genai_logs
2 parents c671e7f + 409cb6a commit d0ebc15

File tree

8 files changed

+1254
-130
lines changed

8 files changed

+1254
-130
lines changed

aws-opentelemetry-distro/src/amazon/opentelemetry/distro/_utils.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111

1212
AGENT_OBSERVABILITY_ENABLED = "AGENT_OBSERVABILITY_ENABLED"
1313

14-
1514
def is_installed(req: str) -> bool:
1615
"""Is the given required package installed?"""
1716

@@ -25,6 +24,5 @@ def is_installed(req: str) -> bool:
2524
return False
2625
return True
2726

28-
2927
def is_agent_observability_enabled() -> bool:
3028
return os.environ.get(AGENT_OBSERVABILITY_ENABLED, "false").lower() == "true"

aws-opentelemetry-distro/src/amazon/opentelemetry/distro/aws_opentelemetry_configurator.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
from typing_extensions import override
1111

1212
from amazon.opentelemetry.distro._aws_attribute_keys import AWS_LOCAL_SERVICE
13+
from amazon.opentelemetry.distro._utils import is_agent_observability_enabled
1314
from amazon.opentelemetry.distro._aws_resource_attribute_configurator import get_service_attribute
1415
from amazon.opentelemetry.distro._utils import is_agent_observability_enabled
1516
from amazon.opentelemetry.distro.always_record_sampler import AlwaysRecordSampler
@@ -166,7 +167,6 @@ def _initialize_components():
166167
sampler = _custom_import_sampler(sampler_name, resource)
167168

168169
logging_enabled = os.getenv(_OTEL_PYTHON_LOGGING_AUTO_INSTRUMENTATION_ENABLED, "false")
169-
170170
if logging_enabled.strip().lower() == "true":
171171
_init_logging(log_exporters, resource)
172172

@@ -371,8 +371,10 @@ def _customize_span_exporter(span_exporter: SpanExporter, resource: Resource) ->
371371

372372
if isinstance(span_exporter, OTLPSpanExporter):
373373
if is_agent_observability_enabled():
374-
375-
span_exporter = OTLPAwsSpanExporter(endpoint=traces_endpoint, logs_provider=get_logger_provider())
374+
span_exporter = OTLPAwsSpanExporter(
375+
endpoint=traces_endpoint,
376+
logger_provider=get_logger_provider()
377+
)
376378
else:
377379
span_exporter = OTLPAwsSpanExporter(endpoint=traces_endpoint)
378380

aws-opentelemetry-distro/src/amazon/opentelemetry/distro/exporter/otlp/aws/traces/otlp_aws_span_exporter.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,10 @@
66
from amazon.opentelemetry.distro._utils import is_agent_observability_enabled
77
from amazon.opentelemetry.distro.exporter.otlp.aws.common.aws_auth_session import AwsAuthSession
88
from amazon.opentelemetry.distro.llo_handler import LLOHandler
9+
from amazon.opentelemetry.distro._utils import is_agent_observability_enabled
10+
from opentelemetry.sdk._logs import LoggerProvider
911
from opentelemetry.exporter.otlp.proto.http import Compression
1012
from opentelemetry.exporter.otlp.proto.http.trace_exporter import OTLPSpanExporter
11-
from opentelemetry.sdk._logs import LoggerProvider
1213
from opentelemetry.sdk.trace import ReadableSpan
1314
from opentelemetry.sdk.trace.export import SpanExportResult
1415

@@ -25,12 +26,12 @@ def __init__(
2526
headers: Optional[Dict[str, str]] = None,
2627
timeout: Optional[int] = None,
2728
compression: Optional[Compression] = None,
28-
logs_provider: Optional[LoggerProvider] = None,
29+
logger_provider: Optional[LoggerProvider] = None
2930
):
3031
self._aws_region = None
3132

32-
if logs_provider:
33-
self._llo_handler = LLOHandler(logs_provider)
33+
if logger_provider:
34+
self._llo_handler = LLOHandler(logger_provider)
3435

3536
if endpoint:
3637
self._aws_region = endpoint.split(".")[1]

0 commit comments

Comments
 (0)