Skip to content

Add nil checks #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Add nil checks #234

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb08a02
Add nil checks
thpierce Aug 16, 2024
604cc10
Update attribute_propagating_span_processor.py
thpierce Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ntelemetry-distro/src/amazon/opentelemetry/distro/attribute_propagating_span_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,9 @@ def on_start(self, span: Span, parent_context: Optional[Context] = None) -> None
if is_local_root(span):
if not _is_server_kind(span):
propagation_data = self._propagation_data_extractor(span)
elif _is_server_kind(parent_span):
elif parent_span and _is_server_kind(parent_span):
propagation_data = self._propagation_data_extractor(parent_span)
else:
elif parent_span:
propagation_data = parent_span.attributes.get(self._propagation_data_key)

if propagation_data is not None:
Expand Down
Loading