Move to public ECR for DockerFile #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit, we are updating the Dockerfile to use python3.11 and rust1.75 images to build the ADOT Python Instrumentation image vended by this repo. This should be a no-op as a) the public ECRs should be mirrors of the DockerHub equivalent and b) these images are only used in the build process, not the final produced image (which is built from `scratch`).
vastin
approved these changes
Aug 23, 2024
srprash
approved these changes
Aug 23, 2024
This was referenced Aug 23, 2024
thpierce
added a commit
that referenced
this pull request
Aug 23, 2024
See #235 There are no plans to ever release another 0.0.x, but for compliance reasons, updating this branch and changing busybox repo. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
thpierce
added a commit
that referenced
this pull request
Aug 23, 2024
See #235 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
thpierce
added a commit
that referenced
this pull request
Aug 23, 2024
See #235 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
thpierce
added a commit
that referenced
this pull request
Aug 23, 2024
See #235 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we are updating the Dockerfile to use python3.11 and rust1.75 images to build the ADOT Python Instrumentation image vended by this repo. This should be a no-op as a) the public ECRs should be mirrors of the DockerHub equivalent and b) these images are only used in the build process, not the final produced image (which is built from
scratch).We will be using:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.