-
Notifications
You must be signed in to change notification settings - Fork 25
Add Application Signals runtime metrics #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e9f772c
to
f6818f9
Compare
srprash
reviewed
Sep 3, 2024
...entelemetry-distro/tests/amazon/opentelemetry/distro/test_aws_opentelementry_configurator.py
Outdated
Show resolved
Hide resolved
...entelemetry-distro/tests/amazon/opentelemetry/distro/test_aws_opentelementry_configurator.py
Outdated
Show resolved
Hide resolved
aws-opentelemetry-distro/src/amazon/opentelemetry/distro/aws_opentelemetry_configurator.py
Outdated
Show resolved
Hide resolved
aws-opentelemetry-distro/src/amazon/opentelemetry/distro/aws_opentelemetry_configurator.py
Outdated
Show resolved
Hide resolved
aws-opentelemetry-distro/src/amazon/opentelemetry/distro/aws_opentelemetry_configurator.py
Outdated
Show resolved
Hide resolved
...opentelemetry-distro/src/amazon/opentelemetry/distro/_aws_resource_attribute_configurator.py
Outdated
Show resolved
Hide resolved
26119ef
to
424e44c
Compare
aws-opentelemetry-distro/src/amazon/opentelemetry/distro/patches/_system_metrics_patch.py
Fixed
Show fixed
Hide fixed
aws-opentelemetry-distro/src/amazon/opentelemetry/distro/patches/_system_metrics_patch.py
Fixed
Show fixed
Hide fixed
62a86e1
to
ec71a68
Compare
mxiamxia
previously approved these changes
Sep 23, 2024
vastin
previously approved these changes
Sep 26, 2024
1f9541d
to
278f6e2
Compare
3c51adc
to
9b6ca07
Compare
vastin
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature request
Add runtime metrics collection into Application Signals. Runtime metrics will be enabled by default if
OTEL_AWS_APPLICATION_SIGNALS_ENABLED
istrue
, and can be disabled separately by settingOTEL_AWS_APPLICATION_SIGNALS_RUNTIME_ENABLED
tofalse
.Description of changes:
ScopeBasedPeriodicExportingMetricReader
to copy metrics fromopentelemetry.instrumentation.system_metrics
instrumentation scope to Application Signals exporter.aws.local.service
into resource attributes.Result example
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.