Changing span unsampled flag to be sampled flag #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxiamxia
approved these changes
Sep 19, 2024
mxiamxia
added a commit
to aws-observability/aws-otel-js-instrumentation
that referenced
this pull request
Sep 21, 2024
*Description of changes:* 1. Replicate Python SDK changes aws-observability/aws-otel-python-instrumentation#260 to rename Unsampled span attribute flag name. 2. Optimize Lambda Layer Deps package config to reduce layer size. 3. Fixed the forceFlush issue which is to set TraceProvider for all instrumentations at the end of init configuration By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Previously we use
aws.trace.flag.unsampledmark the span is unsampled. The change updates this attribute to beaws.trace.flag.sampled.Description of changes:
span is unsampled:
If span has no span attribute aws.trace.flag.sampled , value type is boolean and value is false.
span is sampled:
If span has no span attribute aws.trace.flag.sampled
or span has span attribute aws.trace.flag.sampled , value type is boolean and value is true,
or span has span attribute aws.trace.flag.sampled , value type is NOT boolean
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.