feat: Add CFN Primary ID for Existing Supported AWS Resources #264
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
These changes support AWS Resources with different CFN Identifier formats. This new attribute will have the key
aws.remote.resource.cfn.primary.identifier.More context can be found in the comments of this closed PR: #261
In most cases, this new attribute should have the same value as the existing attribute
aws.remote.resource.identifier.However, there are some edge cases we must handle as seen in this PR:
AWS::SQS::QueueAWS::Bedrock::DataSource|Also updated Bedrock Agent request parameters to also include Knowledge Base ID: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/bedrock-agent/client/get_data_source.html
Test Plan:
Set up a client-server with auto-instrumentation to verify that the correct span data is being generated.
Unit tests for instrumentation


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.