Add new aws resource cloudformation primary identifier attribute in EMF #1357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxiamxia
requested review from
bjrara and
lisguo
and removed request for
a team
mxiamxia
changed the title
bjrara
approved these changes
Sep 26, 2024
lisguo
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add a new log attribute in EMF logs which is to store AWS Resource CloudFormation Primary Identifier value for AWS resources recognized by AppSignals instrumentation SDKs. aws-observability/aws-otel-python-instrumentation#264
Rename SDK attribute
aws.remote.resource.cfn.primary.identifierto EMF logs attributeRemoteResourceCfnPrimaryIdentifierLicense
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
unit test
Requirements
Before commit the code, please do the following steps.
make fmtandmake fmt-shmake lint