fix: update bedrock guardrail cfn primary id to be arn #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzhlogin
reviewed
Oct 10, 2024
aws-opentelemetry-distro/src/amazon/opentelemetry/distro/_aws_metric_attribute_generator.py
Show resolved
Hide resolved
zzhlogin
previously approved these changes
Oct 10, 2024
mxiamxia
reviewed
Oct 11, 2024
aws-opentelemetry-distro/src/amazon/opentelemetry/distro/patches/_bedrock_patches.py
Show resolved
Hide resolved
yiyuan-he
force-pushed
the
update-bedrock
branch
from
d669ee4 to
446a285
Compare
zzhlogin
approved these changes
Oct 11, 2024
mxiamxia
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes:
Updating the CFN Primary Id for Guardrail to be the ARN. (Verified this in the AWS Cloudformation Console)
Testing Plan:
Set up sample apps and manually verified correct span attributes were generated via auto-instrumentation.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.