feat: Add contract tests for new CFN Primary Id attribute and AWS resources #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiyuan-he
changed the title
yiyuan-he
changed the title
yiyuan-he
force-pushed
the
update-contract-tests
branch
from
68a0db2 to
77199b8
Compare
yiyuan-he
force-pushed
the
update-contract-tests
branch
from
cf299f7 to
e65022f
Compare
yiyuan-he
commented
Oct 21, 2024
yiyuan-he
changed the title
mxiamxia
reviewed
Oct 22, 2024
aws-opentelemetry-distro/src/amazon/opentelemetry/distro/patches/_botocore_patches.py
Show resolved
Hide resolved
mxiamxia
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Updating our contract tests to verify the new cloudformation primary id attribute.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.