-
Notifications
You must be signed in to change notification settings - Fork 27
Configure Span Pipeline for BedrockAgentCore #380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure Span Pipeline for BedrockAgentCore #380
Conversation
thpierce
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overview is a bit confusing. The only thing we are doing is: If flag set, add the default logger provider to span exporter. The overview links to https://opentelemetry.io/docs/specs/semconv/gen-ai/gen-ai-events/ as justificaiton for this change, but that page does not mention log anywhere.
In short: I don't know why we are making this change.
aws-opentelemetry-distro/src/amazon/opentelemetry/distro/_utils.py
Outdated
Show resolved
Hide resolved
Upstream OTel has decided for input/output prompt data in Spans, they will split it into |
aws-opentelemetry-distro/src/amazon/opentelemetry/distro/aws_opentelemetry_configurator.py
Show resolved
Hide resolved
Left a comment to the lines of code where I think we can add a high level explanations why logger provider is needed agent case, |
What does this pull request do?
Configures span pipeline for BedrockAgentCore to send traces to OTLP X-Ray endpoint when
AGENT_OBSERVABILITY_ENABLEDis enabled. We also pass an instance oflogger_providerto our custom OTLP Span Exporter since we may need to emit input/output responses to the logs pipeline.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.