feat: Extract resource arn and remote resource access key for cross-account support #396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blairhyy-amazon
force-pushed
the
cross-account
branch
2 times, most recently
from
2894be7 to
60c680c
Compare
bjrara
previously approved these changes
Jun 25, 2025
bjrara
reviewed
Jun 25, 2025
aws-opentelemetry-distro/src/amazon/opentelemetry/distro/_aws_metric_attribute_generator.py
Outdated
Show resolved
Hide resolved
blairhyy-amazon
force-pushed
the
cross-account
branch
2 times, most recently
from
8e86589 to
35d2441
Compare
bjrara
approved these changes
Jul 2, 2025
bjrara
previously approved these changes
Jul 2, 2025
blairhyy-amazon
force-pushed
the
cross-account
branch
from
b1df1b8 to
67ee334
Compare
blairhyy-amazon
force-pushed
the
cross-account
branch
from
2a05b28 to
5bc41ee
Compare
bjrara
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
aws.stream.arnin Span by extracting StreamArn from the request body.aws.table.arnin Span by extracting TableArn from the response body.aws.auth.account.access_keyandaws.auth.regionin Span from STS credentials in client instanceBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.