Skip to content

Conversation

yiyuan-he
Copy link
Contributor

Reverts #388

Why?

Bumping the OTel dependency versions is currently causing our main build due to spans not being generated correctly. For example in an SNS call, we see that aws.local.service is not being populated correctly:

{
    "name": "testTopic send",
    "context": {
        "trace_id": "0x684c92d9eecb9548c12f90342875a8f3",
        "span_id": "0xfd714402fb0429f9",
        "trace_state": "[]"
    },
    "kind": "SpanKind.PRODUCER",
    "parent_id": "0xa6868c3dde9d4839",
    "start_time": "2025-06-13T21:06:33.612183Z",
    "end_time": "2025-06-13T21:06:33.920669Z",
    "status": {
        "status_code": "UNSET"
    },
    "attributes": {
        "rpc.system": "aws-api",
        "rpc.service": "SNS",
        "rpc.method": "Publish",
        "aws.region": "us-west-2",
        "server.address": "sns.us-west-2.amazonaws.com",
        "server.port": 443,
        "messaging.system": "aws.sns",
        "messaging.destination_kind": "topic",
        "messaging.destination": "arn:aws:sns:us-west-2:792479605405:testTopic",
        "messaging.destination.name": "arn:aws:sns:us-west-2:792479605405:testTopic",
        "aws.sns.topic.arn": "arn:aws:sns:us-west-2:792479605405:testTopic",
        "aws.request_id": "8184c44e-c6db-5998-a9d2-a48853c2dd94",
        "retry_attempts": 0,
        "http.status_code": 200
    },
    "events": [],
    "links": [],
    "resource": {
        "attributes": {
            "telemetry.sdk.language": "python",
            "telemetry.sdk.name": "opentelemetry",
            "telemetry.sdk.version": "1.33.0",
            "service.name": "unknown_service",
            "cloud.provider": "aws",
            "cloud.platform": "aws_ec2",
            "cloud.account.id": "445567081046",
            "cloud.region": "us-east-1",
            "cloud.availability_zone": "us-east-1b",
            "host.id": "i-09dfcf17712adbde4",
            "host.type": "c5a.12xlarge",
            "host.name": "ip-172-31-43-64.ec2.internal",
            "telemetry.auto.version": "0.9.0.dev0-aws",
            "aws.local.service": "UnknownService"
        },
        "schema_url": ""
    }
}
{
    "name": "GET /server_request",
    "context": {
        "trace_id": "0x684c92d9eecb9548c12f90342875a8f3",
        "span_id": "0xa6868c3dde9d4839",
        "trace_state": "[]"
    },
    "kind": "SpanKind.SERVER",
    "parent_id": null,
    "start_time": "2025-06-13T21:06:33.610724Z",
    "end_time": "2025-06-13T21:06:33.920935Z",
    "status": {
        "status_code": "UNSET"
    },
    "attributes": {
        "http.method": "GET",
        "http.server_name": "127.0.0.1",
        "http.scheme": "http",
        "net.host.name": "localhost:8082",
        "http.host": "localhost:8082",
        "net.host.port": 8082,
        "http.target": "/server_request?param=.%2Fsample-applications%2Fsimple-client-server%2Fclient.py",
        "net.peer.ip": "127.0.0.1",
        "net.peer.port": 34778,
        "http.user_agent": "python-requests/2.32.2",
        "http.flavor": "1.1",
        "http.route": "/server_request",
        "http.status_code": 200
    },
    "events": [],
    "links": [],
    "resource": {
        "attributes": {
            "telemetry.sdk.language": "python",
            "telemetry.sdk.name": "opentelemetry",
            "telemetry.sdk.version": "1.33.0",
            "service.name": "unknown_service",
            "cloud.provider": "aws",
            "cloud.platform": "aws_ec2",
            "cloud.account.id": "445567081046",
            "cloud.region": "us-east-1",
            "cloud.availability_zone": "us-east-1b",
            "host.id": "i-09dfcf17712adbde4",
            "host.type": "c5a.12xlarge",
            "host.name": "ip-172-31-43-64.ec2.internal",
            "telemetry.auto.version": "0.9.0.dev0-aws",
            "aws.local.service": "UnknownService"
        },
        "schema_url": ""
    }
}

Previously these contract tests were passing in the PR build as well as locally with these dependency version bumps so we are not sure why they are failing all of a sudden. As a short-term mitigation, we will revert these changes as we investigate further.

@yiyuan-he yiyuan-he requested a review from a team as a code owner June 13, 2025 21:21
@yiyuan-he yiyuan-he merged commit a538775 into main Jun 13, 2025
11 checks passed
@yiyuan-he yiyuan-he deleted the revert-388-bump-otel-dependencies-version branch June 13, 2025 21:46
yiyuan-he added a commit to yiyuan-he/aws-otel-python-instrumentation that referenced this pull request Jun 16, 2025
yiyuan-he added a commit to yiyuan-he/aws-otel-python-instrumentation that referenced this pull request Jun 16, 2025
…ility#397)

Reverts aws-observability#388

## Why?
Bumping the OTel dependency versions is currently causing our main build
due to spans not being generated correctly. For example in an SNS call,
we see that `aws.local.service` is not being populated correctly:
```
{
    "name": "testTopic send",
    "context": {
        "trace_id": "0x684c92d9eecb9548c12f90342875a8f3",
        "span_id": "0xfd714402fb0429f9",
        "trace_state": "[]"
    },
    "kind": "SpanKind.PRODUCER",
    "parent_id": "0xa6868c3dde9d4839",
    "start_time": "2025-06-13T21:06:33.612183Z",
    "end_time": "2025-06-13T21:06:33.920669Z",
    "status": {
        "status_code": "UNSET"
    },
    "attributes": {
        "rpc.system": "aws-api",
        "rpc.service": "SNS",
        "rpc.method": "Publish",
        "aws.region": "us-west-2",
        "server.address": "sns.us-west-2.amazonaws.com",
        "server.port": 443,
        "messaging.system": "aws.sns",
        "messaging.destination_kind": "topic",
        "messaging.destination": "arn:aws:sns:us-west-2:792479605405:testTopic",
        "messaging.destination.name": "arn:aws:sns:us-west-2:792479605405:testTopic",
        "aws.sns.topic.arn": "arn:aws:sns:us-west-2:792479605405:testTopic",
        "aws.request_id": "8184c44e-c6db-5998-a9d2-a48853c2dd94",
        "retry_attempts": 0,
        "http.status_code": 200
    },
    "events": [],
    "links": [],
    "resource": {
        "attributes": {
            "telemetry.sdk.language": "python",
            "telemetry.sdk.name": "opentelemetry",
            "telemetry.sdk.version": "1.33.0",
            "service.name": "unknown_service",
            "cloud.provider": "aws",
            "cloud.platform": "aws_ec2",
            "cloud.account.id": "445567081046",
            "cloud.region": "us-east-1",
            "cloud.availability_zone": "us-east-1b",
            "host.id": "i-09dfcf17712adbde4",
            "host.type": "c5a.12xlarge",
            "host.name": "ip-172-31-43-64.ec2.internal",
            "telemetry.auto.version": "0.9.0.dev0-aws",
            "aws.local.service": "UnknownService"
        },
        "schema_url": ""
    }
}
{
    "name": "GET /server_request",
    "context": {
        "trace_id": "0x684c92d9eecb9548c12f90342875a8f3",
        "span_id": "0xa6868c3dde9d4839",
        "trace_state": "[]"
    },
    "kind": "SpanKind.SERVER",
    "parent_id": null,
    "start_time": "2025-06-13T21:06:33.610724Z",
    "end_time": "2025-06-13T21:06:33.920935Z",
    "status": {
        "status_code": "UNSET"
    },
    "attributes": {
        "http.method": "GET",
        "http.server_name": "127.0.0.1",
        "http.scheme": "http",
        "net.host.name": "localhost:8082",
        "http.host": "localhost:8082",
        "net.host.port": 8082,
        "http.target": "/server_request?param=.%2Fsample-applications%2Fsimple-client-server%2Fclient.py",
        "net.peer.ip": "127.0.0.1",
        "net.peer.port": 34778,
        "http.user_agent": "python-requests/2.32.2",
        "http.flavor": "1.1",
        "http.route": "/server_request",
        "http.status_code": 200
    },
    "events": [],
    "links": [],
    "resource": {
        "attributes": {
            "telemetry.sdk.language": "python",
            "telemetry.sdk.name": "opentelemetry",
            "telemetry.sdk.version": "1.33.0",
            "service.name": "unknown_service",
            "cloud.provider": "aws",
            "cloud.platform": "aws_ec2",
            "cloud.account.id": "445567081046",
            "cloud.region": "us-east-1",
            "cloud.availability_zone": "us-east-1b",
            "host.id": "i-09dfcf17712adbde4",
            "host.type": "c5a.12xlarge",
            "host.name": "ip-172-31-43-64.ec2.internal",
            "telemetry.auto.version": "0.9.0.dev0-aws",
            "aws.local.service": "UnknownService"
        },
        "schema_url": ""
    }
}
```

Previously these contract tests were passing in the PR build as well as
locally with these dependency version bumps so we are not sure why they
are failing all of a sudden. As a short-term mitigation, we will revert
these changes as we investigate further.
yiyuan-he added a commit to yiyuan-he/aws-otel-python-instrumentation that referenced this pull request Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants