Bump OTel Dependency Versions to 1.33.1/0.54b1 #399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bility#397) This reverts commit a538775.
yiyuan-he
force-pushed
the
revert-otel-bump-revert
branch
from
f69782a to
f6931f9
Compare
yiyuan-he
force-pushed
the
revert-otel-bump-revert
branch
from
de23d78 to
0977f8a
Compare
yiyuan-he
force-pushed
the
revert-otel-bump-revert
branch
from
0977f8a to
4716d6b
Compare
yiyuan-he
changed the title
yiyuan-he
changed the title
thpierce
reviewed
Jun 17, 2025
There was a problem hiding this comment.
- Lets update to 1.33.1, not 1.33.0.
- We override a good chunk of of upstream code in
aws_opentelemetry_configurator, here. I worry that the upstream may have changed in a subtle way. I think we should do an upstream comparison as a sanity check. Basically just compare each method to the upstream @1.33.1 to see what the diff is.
aws-opentelemetry-distro/src/amazon/opentelemetry/distro/patches/_bedrock_patches.py
Show resolved
Hide resolved
...entelemetry-distro/tests/amazon/opentelemetry/distro/test_aws_opentelementry_configurator.py
Show resolved
Hide resolved
aws-opentelemetry-distro/tests/amazon/opentelemetry/distro/test_instrumentation_patch.py
Show resolved
Hide resolved
aws-opentelemetry-distro/src/amazon/opentelemetry/distro/patches/_botocore_patches.py
Show resolved
Hide resolved
yiyuan-he
changed the title
yiyuan-he
force-pushed
the
revert-otel-bump-revert
branch
2 times, most recently
from
566c3c9 to
4c02feb
Compare
yiyuan-he
force-pushed
the
revert-otel-bump-revert
branch
from
4c02feb to
d176d50
Compare
yiyuan-he
changed the title
|
yiyuan-he
commented
Jun 18, 2025
yiyuan-he
commented
Jun 18, 2025
aws-opentelemetry-distro/tests/amazon/opentelemetry/distro/test_instrumentation_patch.py
Outdated
Show resolved
Hide resolved
mxiamxia
reviewed
Jun 18, 2025
mxiamxia
reviewed
Jun 18, 2025
aws-opentelemetry-distro/src/amazon/opentelemetry/distro/_utils.py
Outdated
Show resolved
Hide resolved
mxiamxia
reviewed
Jun 18, 2025
yiyuan-he
force-pushed
the
revert-otel-bump-revert
branch
from
d307d9e to
deb4baa
Compare
mxiamxia
previously approved these changes
Jun 18, 2025
srprash
reviewed
Jun 18, 2025
aws-opentelemetry-distro/src/amazon/opentelemetry/distro/_utils.py
Outdated
Show resolved
Hide resolved
aws-opentelemetry-distro/src/amazon/opentelemetry/distro/patches/_bedrock_patches.py
Show resolved
Hide resolved
aws-opentelemetry-distro/tests/amazon/opentelemetry/distro/test_instrumentation_patch.py
Outdated
Show resolved
Hide resolved
aws-opentelemetry-distro/tests/amazon/opentelemetry/distro/test_instrumentation_patch.py
Outdated
Show resolved
Hide resolved
yiyuan-he
force-pushed
the
revert-otel-bump-revert
branch
from
53fd0f5 to
22ad013
Compare
yiyuan-he
commented
Jun 19, 2025
aws-opentelemetry-distro/src/amazon/opentelemetry/distro/_utils.py
Outdated
Show resolved
Hide resolved
yiyuan-he
force-pushed
the
revert-otel-bump-revert
branch
from
8da7c01 to
babfd66
Compare
yiyuan-he
force-pushed
the
revert-otel-bump-revert
branch
from
babfd66 to
80c3296
Compare
yiyuan-he
force-pushed
the
revert-otel-bump-revert
branch
from
e486611 to
5f18b40
Compare
mxiamxia
approved these changes
Jun 19, 2025
srprash
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
This reverts commit a538775 to re-apply the OTel dependency update in our ADOT SDK since the root cause of the failing contract tests was fixed: #398.
We also bump the OTel dependency version to sync with our ADOT SDK bump. This solves the issue of our contract tests not catching version bump issues in the PR build.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.