Rename aws.ai.agent.type to aws.service.type for agent observability #415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srprash
approved these changes
Jul 1, 2025
Contributor
There was a problem hiding this comment.
LGTM. However, I have some concerns with introducing aws.service.type without considering cases other than gen_ai_agent. Since it is such a broad attribute, we probably need to have an idea on possible values for it and some spec around those values.
Anyway, I know we want to get this in quickly and I don't have strong suggestions for this right now. Hopefully, this will work out well in the future.
jj22ee
added a commit
to aws-observability/aws-otel-js-instrumentation
that referenced
this pull request
Jul 2, 2025
*Issue #, if available:* JS equivalent of: - aws-observability/aws-otel-python-instrumentation#414 - aws-observability/aws-otel-python-instrumentation#415 *Description of changes:* By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
aws.ai.agent.typeto/and setaws.service.typewith default valuegen_ai_agentif no custom setBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.